From owner-svn-src-all@freebsd.org Fri Aug 26 23:14:14 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F3A98B76A99; Fri, 26 Aug 2016 23:14:13 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (glebi.us [96.95.210.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id DD8A9DF1; Fri, 26 Aug 2016 23:14:13 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id u7QNEC0F076083 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 26 Aug 2016 16:14:13 -0700 (PDT) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id u7QNEC5Z076082; Fri, 26 Aug 2016 16:14:12 -0700 (PDT) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@FreeBSD.org using -f Date: Fri, 26 Aug 2016 16:14:12 -0700 From: Gleb Smirnoff To: Bryan Drewery Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r304244 - head/sys/kern Message-ID: <20160826231412.GP1069@FreeBSD.org> References: <201608162155.u7GLtYp4091232@repo.freebsd.org> <529d7219-4dc9-eb06-2a5d-682c725855f6@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <529d7219-4dc9-eb06-2a5d-682c725855f6@FreeBSD.org> User-Agent: Mutt/1.6.1 (2016-04-27) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Aug 2016 23:14:14 -0000 On Sat, Aug 20, 2016 at 10:18:14AM -0700, Bryan Drewery wrote: B> On 8/16/2016 2:55 PM, Gleb Smirnoff wrote: B> > Author: glebius B> > Date: Tue Aug 16 21:55:34 2016 B> > New Revision: 304244 B> > URL: https://svnweb.freebsd.org/changeset/base/304244 B> > B> > Log: B> > We should not be allowing a timeout to reset when a drain is in progress on B> > it (either async or sync drain). B> > B> > At this moment the only user of drain is TCP, but TCP wouldn't reschedule a B> > callout after it has drained it, since it drains only when a tcpcb is closed. B> > This for now the problem isn't observed. B> > B> > Submitted by: rrs B> B> Should this be MFC'd into 11.0? I'm bit on fence on this. As said this is commit for a problem not observed. I prefer not to touch stable branches for no good reason. -- Totus tuus, Glebius.