From owner-freebsd-fs@freebsd.org Sat Nov 17 05:21:17 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 10CD51125E06 for ; Sat, 17 Nov 2018 05:21:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 820F37ADEB for ; Sat, 17 Nov 2018 05:21:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 410821125E05; Sat, 17 Nov 2018 05:21:16 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 037131125E04 for ; Sat, 17 Nov 2018 05:21:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8D5D57ADE0 for ; Sat, 17 Nov 2018 05:21:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id AAF9D10B39 for ; Sat, 17 Nov 2018 05:21:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wAH5LE7s090298 for ; Sat, 17 Nov 2018 05:21:14 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wAH5LEhJ090281 for fs@FreeBSD.org; Sat, 17 Nov 2018 05:21:14 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 233245] [UFS] [enhancement] Softupdates fails to track dependency between appended data and i_size Date: Sat, 17 Nov 2018 05:21:14 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: cem@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Rspamd-Queue-Id: 820F37ADEB X-Spamd-Result: default: False [0.65 / 15.00]; ASN(0.00)[asn:10310, ipnet:2001:1900:2254::/48, country:US]; local_wl_from(0.00)[freebsd.org]; NEURAL_SPAM_SHORT(0.65)[0.651,0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Nov 2018 05:21:17 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233245 --- Comment #7 from Conrad Meyer --- (In reply to Kirk McKusick from comment #6) Ok, I will leave it on the fs list then. > In about 2000 I used the `special topics' lecture of my advanced code rea= ding > class to do a walk-through of the soft updates code. It is a 2.5 hour vid= eo of > me going through softdep.h and ffs_softdep.c. It predates the addition of= the > journaling support, so reflects a simpler time, but is probably still use= ful to > get a general understanding. I would be willing to make the video availab= le to > you if you want to watch it. I think my employer has licensed some of your video series, but none specifically annotated as around 2000. I see a 2006 "data structures" seri= es where #6 covers UFS, including SU, and a 2009 "intensive code walkthrough" series where #15 is a "special topics," including soft updates. I don't suppose you're referring to one of those? If not, I would certainly apprec= iate a copy of the video. > I believe that commenting code is very important and have tried to do a g= ood > job of it in the soft updates code. So I strongly encourage you to work to > improve it. Often the original author overlooks things that seem obvious = to > them but in fact are confusing to those that are not intimately familiar = with > the code. Absolutely! > So filling in those gaps is a valuable addition. Ok, great. Sounds like I have plenty of direction in how to proceed. :-) --=20 You are receiving this mail because: You are the assignee for the bug.=