From owner-freebsd-hackers@FreeBSD.ORG Thu Nov 1 08:06:48 2012 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 61E978F7; Thu, 1 Nov 2012 08:06:48 +0000 (UTC) (envelope-from phk@phk.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id 18B198FC12; Thu, 1 Nov 2012 08:06:47 +0000 (UTC) Received: from critter.freebsd.dk (critter.freebsd.dk [192.168.61.3]) by phk.freebsd.dk (Postfix) with ESMTP id 2FDE73B6B8; Thu, 1 Nov 2012 08:06:41 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.14.5/8.14.5) with ESMTP id qA186egq014236; Thu, 1 Nov 2012 08:06:40 GMT (envelope-from phk@phk.freebsd.dk) To: Alfred Perlstein Subject: Re: please review: patch to retain device name for dumpdev. In-reply-to: <50921B44.20400@ixsystems.com> From: "Poul-Henning Kamp" References: <50921B44.20400@ixsystems.com> Date: Thu, 01 Nov 2012 08:06:40 +0000 Message-ID: <14235.1351757200@critter.freebsd.dk> X-Mailman-Approved-At: Fri, 02 Nov 2012 02:53:54 +0000 Cc: mav@freebsd.org, hackers@freebsd.org X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2012 08:06:48 -0000 -------- In message <50921B44.20400@ixsystems.com>, Alfred Perlstein writes: >Poul-Henning, what do you think? Is there a nicer way? Perhaps a way >to include the "/dev/$device" I think there are private implemenations where dumpdev is a network thing, so too much magic string editing is probably not a good idea. Given that /dev is really just a view into GEOMs namespace, one could argue for "GEOM:ada0p3" that that may be going overboard in sematic correctness. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.