From owner-svn-src-all@freebsd.org  Fri Nov 13 22:36:31 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 593A6A2EFEE;
 Fri, 13 Nov 2015 22:36:31 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id DC6E7149E;
 Fri, 13 Nov 2015 22:36:29 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.15.2/8.15.2) with ESMTPS id tADMaRoa073703
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Sat, 14 Nov 2015 01:36:27 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.15.2/8.15.2/Submit) id tADMaRlM073702;
 Sat, 14 Nov 2015 01:36:27 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Sat, 14 Nov 2015 01:36:27 +0300
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Steven Hartland <smh@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r290450 - in head: sbin/ifconfig share/man/man4
 sys/net
Message-ID: <20151113223627.GC73031@FreeBSD.org>
References: <201511061533.tA6FXSmq054394@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201511061533.tA6FXSmq054394@repo.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Nov 2015 22:36:31 -0000

On Fri, Nov 06, 2015 at 03:33:28PM +0000, Steven Hartland wrote:
S> Author: smh
S> Date: Fri Nov  6 15:33:27 2015
S> New Revision: 290450
S> URL: https://svnweb.freebsd.org/changeset/base/290450
S> 
S> Log:
S>   Add sysctl to control LACP strict compliance default
S>   
S>   Add net.link.lagg.lacp.default_strict_mode which defines
S>   the default value for LACP strict compliance for created
S>   lagg devices.
S>   
S>   Also:
S>   * Add lacp_strict option to ifconfig(8).
S>   * Fix lagg(4) creation examples.
S>   * Minor style(9) fix.

AFAIU, you are adding the sysctl to close a very short period
of time between cloning a lagg(4) and configuring it.

This is not a pretty solution to the problem. But the network
stack has an API for supplying extra parameters at the cloning
time. The lagg_clone_create() accepts the params, that can
be supplied by ifconfig. If you put there the same arguments you
supply with SIOCGLAGGOPTS, you can create and configure a lagg
in one syscall.

-- 
Totus tuus, Glebius.