From owner-freebsd-arch@FreeBSD.ORG Mon Sep 16 05:26:37 2013 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 6B539A85; Mon, 16 Sep 2013 05:26:37 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 21E7B2CAC; Mon, 16 Sep 2013 05:26:36 +0000 (UTC) Received: from Julian-MBP3.local (ppp121-45-245-177.lns20.per2.internode.on.net [121.45.245.177]) (authenticated bits=0) by vps1.elischer.org (8.14.6/8.14.6) with ESMTP id r8G5QTx1096482 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sun, 15 Sep 2013 22:26:31 -0700 (PDT) (envelope-from julian@freebsd.org) Message-ID: <5236967F.9080901@freebsd.org> Date: Mon, 16 Sep 2013 13:26:23 +0800 From: Julian Elischer User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Warner Losh Subject: Re: IFNAMSIZ/IF_NAMESIZE change proposal References: <9527D72E-5871-4C5E-B2AB-A3BECA4925D4@juniper.net> <19C0CA7F-2857-4533-B5E7-29E1085DE072@bsdimp.com> <523695D8.7010201@freebsd.org> In-Reply-To: <523695D8.7010201@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "freebsd-net@freebsd.org" , Anuranjan Shukla , Marcel Moolenaar , "freebsd-arch@freebsd.org" X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Sep 2013 05:26:37 -0000 On 9/16/13 1:23 PM, Julian Elischer wrote: > On 9/15/13 12:21 AM, Warner Losh wrote: >> On Sep 14, 2013, at 2:44 AM, Anuranjan Shukla wrote: >>> At Juniper Networks, interface name size was needed to be longer >>> than what FreeBSD has. We're trying to reduce our local changes to >>> FreeBSD to allow us an easier time upgrading to newer FreeBSD >>> releases, and support the modularization of the network stack we'd >>> proposed earlier. I'm sending this out to propose changing >>> IFNAMSIZ from 16 to 60 (this is the size we use) in FreeBSD. We >>> don't see any downside (other than increasing the ifreq structure >>> size for one) to doing this, as allowing longer interface names >>> can be handy for vendors. I'd like to hear if there's a strong >>> objection to this. If not, we'd like to get this into to the >>> FreeBSD codebase. Any thoughts/objections highly appreciated. > > Divert already has a problem with 16, since it tries (or fails if > > 8 ) to pack the interface name into the 'unused' > bytes of a sockaddr. > 60 just makes things worse, but since it already fails at 16 I can't > really object. > but it would be nice if we could think of a better mechanism for > divert reinjection. having said that I guess divert could just define a different sockaddr_divert to use instead, sinc eit is a different family. > >> 56 or 64 would be better for alignment, wouldn't it? >> >> Warner >> >> _______________________________________________ >> freebsd-net@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-net >> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >> > > _______________________________________________ > freebsd-arch@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-arch > To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" > >