Date: Mon, 16 Sep 2013 13:26:23 +0800 From: Julian Elischer <julian@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>, Anuranjan Shukla <anshukla@juniper.net>, Marcel Moolenaar <marcelm@juniper.net>, "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org> Subject: Re: IFNAMSIZ/IF_NAMESIZE change proposal Message-ID: <5236967F.9080901@freebsd.org> In-Reply-To: <523695D8.7010201@freebsd.org> References: <9527D72E-5871-4C5E-B2AB-A3BECA4925D4@juniper.net> <19C0CA7F-2857-4533-B5E7-29E1085DE072@bsdimp.com> <523695D8.7010201@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9/16/13 1:23 PM, Julian Elischer wrote: > On 9/15/13 12:21 AM, Warner Losh wrote: >> On Sep 14, 2013, at 2:44 AM, Anuranjan Shukla wrote: >>> At Juniper Networks, interface name size was needed to be longer >>> than what FreeBSD has. We're trying to reduce our local changes to >>> FreeBSD to allow us an easier time upgrading to newer FreeBSD >>> releases, and support the modularization of the network stack we'd >>> proposed earlier. I'm sending this out to propose changing >>> IFNAMSIZ from 16 to 60 (this is the size we use) in FreeBSD. We >>> don't see any downside (other than increasing the ifreq structure >>> size for one) to doing this, as allowing longer interface names >>> can be handy for vendors. I'd like to hear if there's a strong >>> objection to this. If not, we'd like to get this into to the >>> FreeBSD codebase. Any thoughts/objections highly appreciated. > > Divert already has a problem with 16, since it tries (or fails if > > 8 ) to pack the interface name into the 'unused' > bytes of a sockaddr. > 60 just makes things worse, but since it already fails at 16 I can't > really object. > but it would be nice if we could think of a better mechanism for > divert reinjection. having said that I guess divert could just define a different sockaddr_divert to use instead, sinc eit is a different family. > >> 56 or 64 would be better for alignment, wouldn't it? >> >> Warner >> >> _______________________________________________ >> freebsd-net@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-net >> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >> > > _______________________________________________ > freebsd-arch@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-arch > To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5236967F.9080901>