Date: Thu, 4 Feb 2016 16:18:32 +0800 From: Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> To: Kubilay Kocak <koobs@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r407979 - head/mail/py-pyspf Message-ID: <CAMHz58Q1UTHRcinN3Pu_ZLbQ2DT_WqNEsGBU24_SA6fk0XNfKg@mail.gmail.com> In-Reply-To: <56B2EABE.7090903@FreeBSD.org> References: <201602032054.u13KsbGC088315@repo.freebsd.org> <56B2EABE.7090903@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 4, 2016 at 2:07 PM, Kubilay Kocak <koobs@freebsd.org> wrote:
> On 4/02/2016 7:54 AM, Sunpoet Po-Chuan Hsieh wrote:
> > -.if ${PYTHON_REL} <= 3300
> > -RUN_DEPENDS+=
> ${PYTHON_PKGNAMEPREFIX}ipaddr>=0:${PORTSDIR}/devel/py-ipaddr
> > -.endif
> > -
>
> Removing this also causes a regression, and is what r407821 and
> r407820 fixed. (See previous reply)
>
> https://svnweb.freebsd.org/changeset/ports/407821
> https://svnweb.freebsd.org/changeset/ports/407820
>
> Note the conditional includes (<=) 3300, not < 3300.
>
This PYTHON_REL check matches to Python 3.2.x and Python 3.3.0.
However, Python 3.2 (which requires devel/py-ipaddr) was gone and Python
3.3.0 was replaced by 3.3.1 on May, 2013 (r318353).
As a result, I removed this outdated PYTHON_REL check.
Regards,
sunpoet
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58Q1UTHRcinN3Pu_ZLbQ2DT_WqNEsGBU24_SA6fk0XNfKg>