From owner-freebsd-bugs  Sat Oct 19 03:11:46 1996
Return-Path: owner-bugs
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id DAA12389
          for bugs-outgoing; Sat, 19 Oct 1996 03:11:46 -0700 (PDT)
Received: from frig.mt.cs.keio.ac.jp (frig.mt.cs.keio.ac.jp [131.113.32.7])
          by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id DAA12373
          for <bugs@freebsd.org>; Sat, 19 Oct 1996 03:11:41 -0700 (PDT)
Received: (from hosokawa@localhost) by frig.mt.cs.keio.ac.jp (8.6.12+2.4W/3.4Wbeta3) id TAA04109; Sat, 19 Oct 1996 19:11:35 +0900
Date: Sat, 19 Oct 1996 19:11:35 +0900
Message-Id: <199610191011.TAA04109@frig.mt.cs.keio.ac.jp>
To: bugs@freebsd.org
Cc: hosokawa@mt.cs.keio.ac.jp
Subject: type of dk_flags (wd.c) should be longer
From: hosokawa@mt.cs.keio.ac.jp (HOSOKAWA Tatsumi)
X-Mailer: mnews [version 1.18PL3] 1994-08/01(Mon)
Sender: owner-bugs@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

In sys/i386/isa/wd.c:

        short   dk_flags;       /* drive characteristics found */
#define DKFL_SINGLE     0x00004 /* sector at a time mode */
#define DKFL_ERROR      0x00008 /* processing a disk error */
#define DKFL_LABELLING  0x00080 /* readdisklabel() in progress */
#define DKFL_32BIT      0x00100 /* use 32-bit i/o mode */
#define DKFL_MULTI      0x00200 /* use multi-i/o mode */
#define DKFL_BADSCAN    0x00400 /* report all errors */

It seems bit operation to dk_flags results in invalid behavior.  I
think that the type of dk_flags should be longer (ex. long).

--
	HOSOKAWA, Tatsumi              E-mail: hosokawa@mt.cs.keio.ac.jp
	  WWW homepage: http://www.mt.cs.keio.ac.jp/person/hosokawa.html
	Department of Computer Science, Keio University, Yokohama, Japan