From owner-svn-ports-all@freebsd.org Thu May 24 20:55:38 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A25CAEFDFA7; Thu, 24 May 2018 20:55:38 +0000 (UTC) (envelope-from tcberner@gmail.com) Received: from mail-qt0-f181.google.com (mail-qt0-f181.google.com [209.85.216.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 42EAF83A63; Thu, 24 May 2018 20:55:38 +0000 (UTC) (envelope-from tcberner@gmail.com) Received: by mail-qt0-f181.google.com with SMTP id q13-v6so3921131qtp.4; Thu, 24 May 2018 13:55:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=xF8SmMyjIKpK1ENTL/Nt0e/69NKpssKqJLunke7Ff3M=; b=UXXaXUpdDm6WSB+i5fuqGkCjTesGKxTZKsPw+FVrn+v3sjDwyrJpIWAkT35Gsxm8ID c7n8zuJLlNCD00KIc6fZ0V1P56rv0OpL8zljJufij5kyXGGoooS0B+tKQUu/x1VUu+WU 0Za09KSBS/fvYi/1fFSdD7TahHA9tg9YIdQmc+VeD+XDPBJdeuGtt+Tl5wMzQSXC0p4l m5a6inV436KW29t++SAmJGwbC2EVHg5n+EdLVFlJewbpZUDK/4mPINjRE3oazHyQduOU gsGmpy/OJaHdg4DJ+fgQQZ66N5I3Ypqml3BLCwCZq24XLiB3aK0OqqLXznx0mku9mj6s xOHw== X-Gm-Message-State: ALKqPwd93+K5xcKjOqEP4tYKc/26s9hjxIQOZXEw0S6NzuJu9WLZSeTi oOkEr3Nnt0URLQSplQ0xCq4QnMVn X-Google-Smtp-Source: AB8JxZo4UK2oNvE+xi3pxtb7g8Jpzrkx10zuj3VQ/KCou6isvxuSybnT8KI+lPJ2qVPoqSfyqoY7cg== X-Received: by 2002:a0c:a9de:: with SMTP id c30-v6mr8157447qvb.53.1527195331610; Thu, 24 May 2018 13:55:31 -0700 (PDT) Received: from mail-qk0-f171.google.com (mail-qk0-f171.google.com. [209.85.220.171]) by smtp.gmail.com with ESMTPSA id c20-v6sm14968094qkm.59.2018.05.24.13.55.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 May 2018 13:55:31 -0700 (PDT) Received: by mail-qk0-f171.google.com with SMTP id h140-v6so2454094qke.2; Thu, 24 May 2018 13:55:31 -0700 (PDT) X-Received: by 2002:a37:664a:: with SMTP id a71-v6mr8412365qkc.201.1527195331126; Thu, 24 May 2018 13:55:31 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ac8:22b2:0:0:0:0:0 with HTTP; Thu, 24 May 2018 13:55:30 -0700 (PDT) In-Reply-To: References: <201805232159.w4NLxYrK000782@repo.freebsd.org> <1527143137.2894038.1383018096.245EB176@webmail.messagingengine.com> <20180524065529.rtcmylbz5qtnupnx@atuin.in.mat.cc> <20180524105750.tw2vl4v3trg3jhiv@ogg.in.absolight.net> From: "Tobias C. Berner" Date: Thu, 24 May 2018 22:55:30 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r470725 - in head/textproc/tkdiff: . files To: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Cc: Mathieu Arnold , "Tobias C. Berner" , Tobias Kortkamp , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 May 2018 20:55:38 -0000 Yes please :) On 24 May 2018 at 14:08, Fernando Apestegu=C3=ADa wrote: > > > El jue., 24 may. 2018 12:57, Mathieu Arnold escribi=C3= =B3: > >> On Thu, May 24, 2018 at 12:43:57PM +0200, Tobias C. Berner wrote: >> > That was what I suggested initially. >> > >> > But as you commented on the target used to install the file without al= so >> > weighing in on the issue of adding binaries, I assumed it was fine :) >> >> I cannot see everything, and most of the times, when my focus catches on >> a big mistake, like the two targets, it usually means the Makefile has >> larger structural problems that needs addressed first, so I do not delve >> too much on what goes on. When the Makefile looks saner, and a quick >> glance cannot find anything blatantly wrong, I look deeper into things. >> But in any way, I am human, and I miss stuff. >> > > I can prepare an alternative with an icons .tgz distribution and work thi= s > out with the maintainer. > > Sounds good? > > >> > mfg Tobias >> > >> > On 24 May 2018 at 08:55, Mathieu Arnold wrote: >> > >> > > On Thu, May 24, 2018 at 06:25:37AM +0000, Tobias Kortkamp wrote: >> > > > 2. print/jabref, misc/mc, editors/openoffice-devel, etc. seem to >> have >> > > > binary files in files/*.png. Can we add new ones or is it >> forbidden >> > > now? >> > > > It seems weird to have to base64 encode icons and decode them >> during >> > > the >> > > > build. >> > > >> > > I think it would be better to keep binary files out of the ports tre= e. >> > > It's probably as easy to drop them in LOCAL/user, either individuall= y >> or >> > > in an archive. >> > > >> > > -- >> > > Mathieu Arnold >> > > >> >> -- >> Mathieu Arnold >> >