From owner-cvs-all@FreeBSD.ORG Fri Nov 25 19:55:16 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4FC6916A41F; Fri, 25 Nov 2005 19:55:16 +0000 (GMT) (envelope-from avatar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E1BE543D5E; Fri, 25 Nov 2005 19:55:14 +0000 (GMT) (envelope-from avatar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id jAPJtEAb081679; Fri, 25 Nov 2005 19:55:14 GMT (envelope-from avatar@repoman.freebsd.org) Received: (from avatar@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id jAPJtEqC081673; Fri, 25 Nov 2005 19:55:14 GMT (envelope-from avatar) Message-Id: <200511251955.jAPJtEqC081673@repoman.freebsd.org> From: Tai-hwa Liang Date: Fri, 25 Nov 2005 19:55:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/mount_msdosfs mount_msdosfs.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Nov 2005 19:55:16 -0000 avatar 2005-11-25 19:55:14 UTC FreeBSD src repository Modified files: sbin/mount_msdosfs mount_msdosfs.c Log: It turns out that set_charset() invokes build_iovec_argf() which modifies iov address internally through realloc(3). However, since the function parameter wasn't designed to allow the modified iov being passed back to the caller, we ended up feeding iov with several corrupted entries(this depends on how many arguments were pushed into iovec before set_charset()) to nmount(2). This commit fixes this regression introduced in rev1.37 such that mount_msdosfs(8) with code page conversion option(-W,-D) enabled works again. Reviewed by: rodrigc Revision Changes Path 1.40 +6 -6 src/sbin/mount_msdosfs/mount_msdosfs.c