From owner-cvs-sys Tue Aug 12 00:13:43 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id AAA06776 for cvs-sys-outgoing; Tue, 12 Aug 1997 00:13:43 -0700 (PDT) Received: from lestat.nas.nasa.gov (lestat.nas.nasa.gov [129.99.50.29]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id AAA06771; Tue, 12 Aug 1997 00:13:39 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by lestat.nas.nasa.gov (8.8.6/8.6.12) with SMTP id AAA23636; Tue, 12 Aug 1997 00:08:12 -0700 (PDT) Message-Id: <199708120708.AAA23636@lestat.nas.nasa.gov> X-Authentication-Warning: lestat.nas.nasa.gov: localhost [127.0.0.1] didn't use HELO protocol To: Sean Eric Fagan Cc: cvs-committers@freebsd.org, cvs-all@freebsd.org, cvs-sys@freebsd.org Subject: Re: cvs commit: src/sys/miscfs/procfs procfs.h procfs_mem.c procfs_regs.c procfs_vnops.c Reply-To: Jason Thorpe From: Jason Thorpe Date: Tue, 12 Aug 1997 00:08:11 -0700 Sender: owner-cvs-sys@freebsd.org X-Loop: FreeBSD.org Precedence: bulk On Mon, 11 Aug 1997 21:34:31 -0700 (PDT) Sean Eric Fagan wrote: > sef 1997/08/11 21:34:31 PDT > > Modified files: > sys/miscfs/procfs procfs.h procfs_mem.c procfs_regs.c > procfs_vnops.c > Log: > Fix procfs security hole -- check permissions on meaningful I/Os (namely, > reading/writing of mem and regs). Also have to check for the requesting > process being group KMEM -- this is a bit of a hack, but ps et al need it. This is why ps(1) shouldn't use procfs :-) In any case, it's probably also reasonable to allow uid 0 to perform said i/o on setuid processes. IIRC, this would make it the same as the constraints on ptrace(2). Jason R. Thorpe thorpej@nas.nasa.gov NASA Ames Research Center Home: +1 408 866 1912 NAS: M/S 258-6 Work: +1 415 604 0935 Moffett Field, CA 94035 Pager: +1 415 428 6939