From owner-freebsd-current@FreeBSD.ORG Mon Jul 18 21:35:27 2005 Return-Path: X-Original-To: freebsd-current@FreeBSD.ORG Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A7BEC16A41C; Mon, 18 Jul 2005 21:35:27 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.village.org (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 40DA543D46; Mon, 18 Jul 2005 21:35:27 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1]) by harmony.village.org (8.13.3/8.13.3) with ESMTP id j6ILYJrY085511; Mon, 18 Jul 2005 15:34:20 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 18 Jul 2005 15:35:04 -0600 (MDT) Message-Id: <20050718.153504.32720462.imp@bsdimp.com> To: jhb@FreeBSD.ORG From: "M. Warner Losh" In-Reply-To: <200507181619.31189.jhb@FreeBSD.org> References: <4.3.2.7.2.20050716124022.01f08460@mail.qconline.com> <20050716.125824.48530425.imp@bsdimp.com> <200507181619.31189.jhb@FreeBSD.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: freebsd-current@FreeBSD.ORG, harrycoin@qconline.com, nate@root.org Subject: Re: mss.c pcm fix to ' attach returned 6 ' load failure for v5.x acpi and up X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2005 21:35:27 -0000 In message: <200507181619.31189.jhb@FreeBSD.org> John Baldwin writes: : On Saturday 16 July 2005 02:58 pm, M. Warner Losh wrote: : > : dmesg excerpt ... : > : mss_probe: bus acpi0 is probing device pcm0 : > : mss_probe: isa_get_logicalid() returned 0! : > : > This is the problem. It shouldn't be probing there. It doesn't in : > current. Chances are John beat me to it and we're arguing over : > something that's been fixed... : : I removed that probe in current. The problem is that ACPI has HID values that : are strings like "ACPI0003" that don't fit the EISAID model, so for devices : like ACPI thermal zones that only have an ACPI HID, there's no PNP-compatible : HID or CID to return to the ISA drivers. I think the proper solution is that : drivers that don't support ACPI-enumerate devices (recall that ACPI : enumerates PNPBIOS devices) need to stop having acpi attachments, and that : drivers that do need to use ISA_PNP_PROBE(). I think that the only embedded : sound controllers are PCI, so that probably all of the ISA PNP sound drivers : don't need acpi attachments but I could be wrong. If we're going to return the string that we found, maybe it would be better to return a pointer isa_pnp_id entry, and also pass in in the length of the table entry so that drivers can store extra info for each card. PC Card already does this for its lookup routines, for example, that that has worked out very well. That way there isn't the weird trip to a string, then a lookup based on that string. Warner