From owner-freebsd-ports  Mon Aug 24 04:09:18 1998
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id EAA09721
          for freebsd-ports-outgoing; Mon, 24 Aug 1998 04:09:18 -0700 (PDT)
          (envelope-from owner-freebsd-ports@FreeBSD.ORG)
Received: from vader.cs.berkeley.edu (vader.CS.Berkeley.EDU [128.32.38.234])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id EAA09716
          for <ports@freebsd.org>; Mon, 24 Aug 1998 04:09:16 -0700 (PDT)
          (envelope-from asami@vader.cs.berkeley.edu)
Received: from silvia.hip.berkeley.edu (sji-ca10-63.ix.netcom.com [205.186.214.63]) by vader.cs.berkeley.edu (8.8.7/8.7.3) with ESMTP id EAA20142; Mon, 24 Aug 1998 04:08:25 -0700 (PDT)
Received: (from asami@localhost) by silvia.hip.berkeley.edu (8.8.8/8.6.9) id EAA11885; Mon, 24 Aug 1998 04:08:16 -0700 (PDT)
Date: Mon, 24 Aug 1998 04:08:16 -0700 (PDT)
Message-Id: <199808241108.EAA11885@silvia.hip.berkeley.edu>
To: andy@icc.surw.chel.su
CC: ports@FreeBSD.ORG
Subject: do-install targets in games/*/Makefiles
From: asami@cs.berkeley.edu (Satoshi Asami)
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

Hi,

I just noticed that a lot of your Makefiles in games have a do-install
target that uses ${INSTALL_PROGRAM} and ${INSTALL_MAN} to install a
single binary and manpage (and sometimes the app-defaults file).  What
is the purpose of this?

The only difference I can tell is that if the do-install target is
taken away, the port will put the manpage in section 1 instead of
section 6.

If that's the case, I don't think it's worth the complication.
Duplicating pretty much what the original makefile already does in the 
port makefile is not very good programming practice.

If I were you, I'd just move the manpage in post-install.  Here's an
example:

===
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/games/xquarto/Makefile,v
retrieving revision 1.2
diff -u -r1.2 Makefile
--- Makefile	1998/07/27 23:25:20	1.2
+++ Makefile	1998/08/24 11:02:47
@@ -17,8 +17,7 @@
 USE_IMAKE=	yes
 MAN6=		xquarto.6
 
-do-install:
-	@ ${INSTALL_PROGRAM} ${WRKSRC}/src/xquarto ${PREFIX}/bin
-	@ ${INSTALL_DATA} ${WRKSRC}/src/xquarto.man ${PREFIX}/man/man6/xquarto.6
+post-install:
+	${MV} ${PREFIX}/man/man1/xquarto.1.gz ${PREFIX}/man/man6/xquarto.6.gz
 
 .include <bsd.port.mk>
===

Or just forget about the whole man6 thing and just put it in section
1.  It's not like there are commands that both appear in section 6 and 
1, and most commands put the manpages in 1 anyway. ;)

Satoshi

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message