From owner-freebsd-ports-bugs@freebsd.org  Tue Jan 31 01:50:57 2017
Return-Path: <owner-freebsd-ports-bugs@freebsd.org>
Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 71CD7CC7F42
 for <freebsd-ports-bugs@mailman.ysv.freebsd.org>;
 Tue, 31 Jan 2017 01:50:57 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 602BFD22
 for <freebsd-ports-bugs@FreeBSD.org>; Tue, 31 Jan 2017 01:50:57 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v0V1ovHT067394
 for <freebsd-ports-bugs@FreeBSD.org>; Tue, 31 Jan 2017 01:50:57 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 216633] x11/slim: fails to build with clang 4.0
Date: Tue, 31 Jan 2017 01:50:57 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: needs-patch
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: henry.hu.sh@gmail.com
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org
X-Bugzilla-Flags: maintainer-feedback?
X-Bugzilla-Changed-Fields: flagtypes.name attachments.created
Message-ID: <bug-216633-13-xVFTDYn0wN@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-216633-13@https.bugs.freebsd.org/bugzilla/>
References: <bug-216633-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Jan 2017 01:50:57 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D216633

Henry Hu <henry.hu.sh@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #179453|                            |maintainer-approval+
              Flags|                            |

--- Comment #1 from Henry Hu <henry.hu.sh@gmail.com> ---
Created attachment 179453
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D179453&action=
=3Dedit
patch to fix build

I don't have clang 4.0 for now, so I can't test it, but this patch should w=
ork.
Honestly, I think that this check should be removed. From Xlib.h:
/*
 * Graphics context.  The contents of this structure are implementation
 * dependent.  A GC should be treated as opaque by application code.
 */
XCreateGC's man page does not mention what the return value would be if it
failed, and after checking 10 pages of github search results, no one checked
the return value of XCreateGC.
However, given that GC is a pointer, checking it against NULL should serve =
the
purpose.

--=20
You are receiving this mail because:
You are the assignee for the bug.=