From owner-svn-src-head@freebsd.org  Tue Jul 28 07:06:03 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id F170E9AB08F
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Tue, 28 Jul 2015 07:06:03 +0000 (UTC) (envelope-from ed@nuxi.nl)
Received: from mail-oi0-f41.google.com (mail-oi0-f41.google.com
 [209.85.218.41])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id A47F91C61
 for <svn-src-head@freebsd.org>; Tue, 28 Jul 2015 07:06:03 +0000 (UTC)
 (envelope-from ed@nuxi.nl)
Received: by oihq81 with SMTP id q81so64557917oih.2
 for <svn-src-head@freebsd.org>; Tue, 28 Jul 2015 00:05:57 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=+ofwWkWUZr4n561/0OwI5brLcnIiLD2WnpNVaKKxyw0=;
 b=kAXLj3MSCxG29XgTQRQkkULXd+ddCNCX13j5FhJGal+ZuGPNgxCHG9cwCyJXS9nyh3
 yPlC7g/lNu/B7VN1Wu5JFQuKRg1oh3xMiODPPLU2M2hGW0IZboVuu4/r0KCctXxwatP0
 ZQXJPq1TrvJ+MyLvVsc4Sj8XmDs8YFcIKDImRYwwNSr6UYK2J8cWhYeFNQ94dPwF5EYM
 O/LILXMuNzYjPpuLRwGgjIkwPHe2GgsIzz8HA36zxb95AI5my7k/8z0m3x7tQYlnyTZA
 kVt8y5yjgvMWJnahpBoIr0jMAsHtkc858WTkAWOgrtb1EVPc2+Vn6iU0eWXhMaExd+mb
 ac0w==
X-Gm-Message-State: ALoCoQme3HepLFd9fFILpPe+p/95DEFCZF+hnccPKcLwnZtaK0gyCM+jLloeR+lZxMwlBhRWOdJi
MIME-Version: 1.0
X-Received: by 10.202.67.67 with SMTP id q64mr30972771oia.124.1438067157389;
 Tue, 28 Jul 2015 00:05:57 -0700 (PDT)
Received: by 10.76.0.46 with HTTP; Tue, 28 Jul 2015 00:05:57 -0700 (PDT)
X-Originating-IP: [84.27.222.46]
In-Reply-To: <201507280232.t6S2WfSq043383@repo.freebsd.org>
References: <201507280232.t6S2WfSq043383@repo.freebsd.org>
Date: Tue, 28 Jul 2015 09:05:57 +0200
Message-ID: <CABh_MKmssa3h8MKJawKj_thECxGwCa9cLd5fcwL035_5GHtomw@mail.gmail.com>
Subject: Re: svn commit: r285926 - in head: libexec/ypxfr usr.bin/ypcat
 usr.bin/ypmatch usr.bin/ypwhich usr.sbin/yp_mkdb usr.sbin/yppush
 usr.sbin/ypserv
From: Ed Schouten <ed@nuxi.nl>
To: Marcelo Araujo <araujo@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jul 2015 07:06:04 -0000

Hi Marcelo,

Thanks for working on this!

2015-07-28 4:32 GMT+02:00 Marcelo Araujo <araujo@freebsd.org>:
> -struct ypalias {
> +const struct ypalias {
>         char *alias, *name;
> -} ypaliases[] = {
> +} static ypaliases[] = {
>         { "passwd", "passwd.byname" },
>         { "master.passwd", "master.passwd.byname" },
>         { "shadow", "shadow.byname" },

I seem to remember that certain compilers (Intel?) are pretty picky
about the ordering of 'static' and 'const'.

const static int i; // Compiler error.

It's also inconsistent with the rest of our codebase, where we
typically put 'static' in front of the type. Could you please change
this to the following?

static const struct ypalias {
   ...
} ypaliases[] = {
   ...
};

Thanks!

-- 
Ed Schouten <ed@nuxi.nl>
Nuxi, 's-Hertogenbosch, the Netherlands
KvK/VAT number: 62051717