From owner-svn-src-all@freebsd.org Fri Oct 18 14:24:20 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7F3EA152489; Fri, 18 Oct 2019 14:24:20 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 46vpFH0J7Fz4dD6; Fri, 18 Oct 2019 14:24:18 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id LTAriWW3rsAGkLTAsiWXof; Fri, 18 Oct 2019 08:24:16 -0600 X-Authority-Analysis: v=2.3 cv=WeVylHpX c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=XobE76Q3jBoA:10 a=pGLkceISAAAA:8 a=iaTFZB6CAAAA:8 a=6I5d2MoRAAAA:8 a=G0_B3m8xAAAA:8 a=YxBL1-UpAAAA:8 a=_hhXOdq3uOJBmoHTGhIA:9 a=jPecpB6AOpLXUzJM:21 a=CjuIK1q_8ugA:10 a=QWXrQ9iV8q7LKaLQ9lfw:22 a=IjZwj45LgO3ly-622nXo:22 a=gBgTPrObzSPeouD7eQ2s:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id E680F2E2; Fri, 18 Oct 2019 07:24:12 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id x9IEOC83013888; Fri, 18 Oct 2019 07:24:12 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id x9IEOC9q013885; Fri, 18 Oct 2019 07:24:12 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201910181424.x9IEOC9q013885@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: "Hartmann, O." cc: Gary Jennejohn , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Conrad Meyer Subject: Re: svn commit: r353700 - in head: share/man/man4 sys/amd64/conf sys/conf sys/gdb sys/i386/conf sys/kern sys/net sys/sys In-reply-to: <20191018160935.7dda61c4@hermann.fritz.box> References: <201910172133.x9HLX1kl071044@repo.freebsd.org> <20191018122104.389ffb7a@hermann.fritz.box> <20191018140045.31d269b0@ernst.home> <20191018160935.7dda61c4@hermann.fritz.box> Comments: In-reply-to "Hartmann, O." message dated "Fri, 18 Oct 2019 16:09:35 +0200." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 18 Oct 2019 07:24:12 -0700 X-CMAE-Envelope: MS4wfAQvcwMHM8/AO/ezVkeFJlc9BKXzf4wEO1n6TnUm6OLdgTeq/EEakSb8hDxirVltu0sxMiKziimbKlCbz0zq14xsfv0p34g6zeCjqTKf1SaqL2kKgE7C A7BiZtlklMQWXtAzk56gpjX4phGhH+8nQ1b947IlC+OebeBqTN2/0OZLpGcUdSK1kQddb7+EyPmqNthGki0kT9iflEWXucH1g22qh7+XvYUBsPWr/nUEuGXx oftX1zhDlc9VkXfF86/bDC9SbtuePzmEWuXshhxwe3WbjA7USnyau3olJ9Mzo23D0N8F1gBK1nNz7fBanfI05w== X-Rspamd-Queue-Id: 46vpFH0J7Fz4dD6 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 64.59.134.12) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [-3.97 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; IP_SCORE(-2.37)[ip: (-6.33), ipnet: 64.59.128.0/20(-3.05), asn: 6327(-2.37), country: CA(-0.09)]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_FIVE(0.00)[6]; REPLYTO_EQ_FROM(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[12.134.59.64.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; FREEMAIL_CC(0.00)[gmail.com]; RCVD_TLS_LAST(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[12.134.59.64.rep.mailspike.net : 127.0.0.17] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Oct 2019 14:24:20 -0000 In message <20191018160935.7dda61c4@hermann.fritz.box>, "Hartmann, O." writes: > --Sig_/QDD9BZgeMM6.TJkOIciNb32 > Content-Type: text/plain; charset=US-ASCII > Content-Transfer-Encoding: quoted-printable > > On Fri, 18 Oct 2019 14:00:45 +0200 > Gary Jennejohn wrote: > > > On Fri, 18 Oct 2019 12:21:04 +0200 > > "Hartmann, O." wrote: > >=20 > > > On Thu, 17 Oct 2019 21:33:01 +0000 (UTC) > > > Conrad Meyer wrote: > > > =20 > > > > Author: cem > > > > Date: Thu Oct 17 21:33:01 2019 > > > > New Revision: 353700 > > > > URL: https://svnweb.freebsd.org/changeset/base/353700 > > > >=20 > > > > Log: > > > > Implement NetGDB(4) > > > > =20 > > > > NetGDB(4) is a component of a system using a panic-time network > > > > stack to remotely debug crashed FreeBSD kernels over the network, > > > > instead of traditional serial interfaces. > > > > =20 > > > > There are three pieces in the complete NetGDB system. > > > > =20 > > > > First, a dedicated proxy server must be running to accept > > > > connections from both NetGDB and gdb(1), and pass bidirectional > > > > traffic between the two protocols. > > > > =20 > > > > Second, the NetGDB client is activated much like ordinary 'gdb' > > > > and similarly to 'netdump' in ddb(4) after a panic. Like other > > > > debugnet(4) clients (netdump(4)), the network interface on the > > > > route to the proxy server must be online and support debugnet(4). > > > > =20 > > > > Finally, the remote (k)gdb(1) uses 'target remote > > > > :' (like any other TCP remote) to connect to the > > > > proxy server.=20 > > > > The NetGDB v1 protocol speaks the literal GDB remote serial > > > > protocol, and uses a 1:1 relationship between GDB packets and > > > > sequences of debugnet packets (fragmented by MTU). There is no > > > > encryption utilized to keep debugging sessions private, so this is > > > > only appropriate for local segments or trusted networks. > > > > =20 > > > > Submitted by: John Reimer > > > > (earlier version) Discussed some with: emaste, markj > > > > Relnotes: sure > > > > Differential Revision: https://reviews.freebsd.org/D21568 > > > >=20 > > > > Added: > > > > head/share/man/man4/netgdb.4 (contents, props changed) > > > > head/sys/gdb/netgdb.c (contents, props changed) > > > > head/sys/gdb/netgdb.h (contents, props changed) > > > > Modified: > > > > head/share/man/man4/Makefile > > > > head/share/man/man4/ddb.4 > > > > head/sys/amd64/conf/GENERIC > > > > head/sys/conf/NOTES > > > > head/sys/conf/files > > > > head/sys/conf/options > > > > head/sys/gdb/gdb.h > > > > head/sys/gdb/gdb_int.h > > > > head/sys/gdb/gdb_main.c > > > > head/sys/gdb/gdb_packet.c > > > > head/sys/i386/conf/GENERIC > > > > head/sys/kern/subr_kdb.c > > > > head/sys/net/debugnet.c > > > > head/sys/net/debugnet.h > > > > head/sys/net/debugnet_inet.c > > > > head/sys/net/debugnet_int.h > > > > head/sys/sys/kdb.h > > > > head/sys/sys/param.h > > > >=20 > > > > Modified: head/share/man/man4/Makefile > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D=3D=3D > > > > --- head/share/man/man4/Makefile Thu Oct 17 21:25:50 > > > > 2019 (r353699) +++ head/share/man/man4/Makefile Thu > > > > Oct 17 21:33:01 2019 (r353700) @@ -307,6 +307,7 @@ MAN=3D > > > > aac.4 \ net80211.4 \ > > > > netdump.4 \ > > > > netfpga10g_nf10bmac.4 \ > > > > + netgdb.4 \ > > > > netgraph.4 \ > > > > netintro.4 \ > > > > netmap.4 \ > > > > =20 > > > [...] > > >=20 > > >=20 > > > Having "nooptions NETGDB # netgdb(4) client support" > > > defined in my kernel config file, buildkernel fails with the error > > > shown below. > > >=20 > > > [...] > > > --- debugnet.o --- > > > /usr/src/sys/net/debugnet.c:662:4: error: implicit declaration of > > > function 'db_printf' is invalid in C99 > > > [-Werror,-Wimplicit-function-declaration] db_printf("%s: Could not > > > get route for that server.\n", ^ /usr/src/sys/net/debugnet.c:662:4: > > > note: did you mean 'if_printf'? /usr/src/sys/net/if_var.h:679:5: > > > note: 'if_printf' declared here int if_printf(struct ifnet *, > > > const char *, ...) __printflike(2, 3); ^ > > > 1 error generated. =20 > >=20 > > And I also had to add "nooptions NETDUMP" to get the kernel to compile > > and link. > >=20 > > I already had "nooptions NETDUMP" defined. This will fix it. Index: sys/net/debugnet.c =================================================================== --- sys/net/debugnet.c (revision 353717) +++ sys/net/debugnet.c (working copy) @@ -659,8 +659,10 @@ CURVNET_RESTORE(); if (dest_rt == NULL) { +#ifdef DDB db_printf("%s: Could not get route for that server.\n", __func__); +#endif error = ENOENT; goto cleanup; } -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.