From owner-cvs-all@FreeBSD.ORG Sat Jun 14 23:55:54 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 55B8A37B401; Sat, 14 Jun 2003 23:55:54 -0700 (PDT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8B58743F85; Sat, 14 Jun 2003 23:55:53 -0700 (PDT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.12.9/8.12.9) with ESMTP id h5F6sFYA093525; Sun, 15 Jun 2003 02:54:15 -0400 (EDT) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)h5F6sFEm093522; Sun, 15 Jun 2003 02:54:15 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Sun, 15 Jun 2003 02:54:15 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org In-Reply-To: <200306150646.h5F6kOn0078427@repoman.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: cvs commit: src/usr.bin/quota Makefile quota.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jun 2003 06:55:54 -0000 Apparently I hit Ctrl-C at the wrong moment during the commit; the followup commit corrects the conflict nits. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories On Sat, 14 Jun 2003, Robert Watson wrote: > rwatson 2003/06/14 23:46:24 PDT > > FreeBSD src repository > > Modified files: > usr.bin/quota Makefile quota.c > Log: > Now that the kernel access control for quotactl(2) appears to work > properly, clean up quota(1). quota(1) has the ability to query > quotas either directly from the kernel, or if that fails, by reading > the quota.user or quota.group files specified for the file system > in /etc/fstab. The setuid bit existed solely (apparently) to let > non-operator users query their quotas and consumption when quotas > weren't enabled for the file system. > > o Remove the setuid bit from quota(1). > > o Remove the logic used by quota(1) when running setuid to prevent > users from querying the quotas of other users or groups. Note > that this papered over previously broken kernel access control. > > Revision Changes Path > 1.5 +0 -1 src/usr.bin/quota/Makefile > 1.19 +0 -17 src/usr.bin/quota/quota.c >