From owner-freebsd-stable@FreeBSD.ORG Sun Feb 27 02:54:39 2005 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BD1C416A4CE for ; Sun, 27 Feb 2005 02:54:39 +0000 (GMT) Received: from mail.chesapeake.net (chesapeake.net [208.142.252.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1FA8E43D48 for ; Sun, 27 Feb 2005 02:54:39 +0000 (GMT) (envelope-from jroberson@chesapeake.net) Received: from mail.chesapeake.net (localhost [127.0.0.1]) by mail.chesapeake.net (8.12.10/8.12.10) with ESMTP id j1R2ppVp051386; Sat, 26 Feb 2005 21:51:51 -0500 (EST) (envelope-from jroberson@chesapeake.net) Received: from localhost (jroberson@localhost)j1R2poPk051379; Sat, 26 Feb 2005 21:51:51 -0500 (EST) (envelope-from jroberson@chesapeake.net) X-Authentication-Warning: mail.chesapeake.net: jroberson owned process doing -bs Date: Sat, 26 Feb 2005 21:51:50 -0500 (EST) From: Jeff Roberson To: Francois Tigeot In-Reply-To: <20050224125148.GA22855@aoi.wolfpond.org> Message-ID: <20050226215116.T50530@mail.chesapeake.net> References: <20050224031645.A86246@mail.chesapeake.net> <20050224125148.GA22855@aoi.wolfpond.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: stable@freebsd.org Subject: Re: Merging phk's filedesc cleanup and lock pushdown. X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Feb 2005 02:54:39 -0000 Fixed the build and merged this. Any stable users who can should test this. I'm very confident in it, but more eyes and users are better. Thanks, Jeff On Thu, 24 Feb 2005, Francois Tigeot wrote: > On Thu, Feb 24, 2005 at 03:18:49AM -0500, Jeff Roberson wrote: > > I am going to MFC phk's filedesc related work in the next few days. This > > is required if I am ever to merge the vfs smp changes. I have a patch > > available at: > > > > http://www.chesapeake.net/~jroberson/fdesc.patch > > > > I'd appreciate it if anyone who can would test this. It has been running > > on current for 3-4 months, depending on the bit, but there's always a > > chance of a botched merge. > > World doesn't build with this patch: > > cc -O -pipe -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type > -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -c > /usr/src/usr.bin/fstat/fstat.c > /usr/src/usr.bin/fstat/fstat.c: In function `dofiles': > /usr/src/usr.bin/fstat/fstat.c:325: error: storage size of 'filed0' isn't known > /usr/src/usr.bin/fstat/fstat.c:363: error: `NDFILE' undeclared (first use in this function) > /usr/src/usr.bin/fstat/fstat.c:363: error: (Each undeclared identifier is reported only once > /usr/src/usr.bin/fstat/fstat.c:363: error: for each function it appears in.) > /usr/src/usr.bin/fstat/fstat.c:325: warning: unused variable `filed0' > *** Error code 1 > > Stop in /usr/src/usr.bin/fstat. > *** Error code 1 > > Stop in /usr/src/usr.bin. > *** Error code 1 > > Stop in /usr/src. > *** Error code 1 > > Stop in /usr/src. > *** Error code 1 > > Stop in /usr/src. > nice make buildworld 1209,00s user 251,75s system 78% cpu 31:04,65 total > > This machine is an amd64 5.3-STABLE host. The same sources build nicely > without the patch. > > -- > Francois Tigeot >