From owner-svn-ports-all@freebsd.org Fri Jan 5 02:42:40 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A3C28EA8EC3; Fri, 5 Jan 2018 02:42:40 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mouf.net", Issuer "mouf.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 65CC36F54F; Fri, 5 Jan 2018 02:42:40 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from lrrr.mouf.net (cpe-24-163-43-246.nc.res.rr.com [24.163.43.246]) (authenticated bits=0) by mouf.net (8.14.9/8.14.9) with ESMTP id w052gWJk092243 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 5 Jan 2018 02:42:38 GMT (envelope-from swills@FreeBSD.org) Subject: Re: svn commit: r457907 - in head/net/rubygem-grpc: . files To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201801021606.w02G6xxJ033897@repo.freebsd.org> <20180103075744.GA2731@FreeBSD.org> From: Steve Wills Message-ID: Date: Thu, 4 Jan 2018 21:42:27 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20180103075744.GA2731@FreeBSD.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mouf.net [199.48.129.64]); Fri, 05 Jan 2018 02:42:38 +0000 (UTC) X-Spam-Status: No, score=0.0 required=4.5 tests=none autolearn=unavailable autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mouf.net X-Virus-Scanned: clamav-milter 0.99.2 at mouf.net X-Virus-Status: Clean X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jan 2018 02:42:40 -0000 Hi, On 01/03/2018 02:57, Alexey Dokuchaev wrote: > > Would you consider patching grpc.gemspec with sed(1) instead? It is > not particularly pretty, but not as ugly as 10K pre-generated binary > file with messed up svn properties. > > It also places ${RM} -r of those files and directories and subsequent > grpc.gemspec fixup closer together (rather than one part done in the > `post-extract' target and fixup ... well, somewhere else). > > It produces exactly the same result as current `files/grpc.gemspec'. I generally don't like to use REINPLACE_CMD when a patch will do, because it can silently stop working, but in this case it works well and seems like a better alternative. So sure, contact the maintainer with a patch, I'm sure he'll approve it. Steve