From owner-freebsd-hackers@FreeBSD.ORG  Sat Nov  6 19:17:03 2010
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 322B0106566B;
	Sat,  6 Nov 2010 19:17:03 +0000 (UTC)
	(envelope-from gljennjohn@googlemail.com)
Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com
	[209.85.214.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 81EE28FC12;
	Sat,  6 Nov 2010 19:17:02 +0000 (UTC)
Received: by bwz3 with SMTP id 3so3677899bwz.13
	for <multiple recipients>; Sat, 06 Nov 2010 12:17:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=googlemail.com; s=gamma;
	h=domainkey-signature:received:received:date:from:to:cc:subject
	:message-id:in-reply-to:references:reply-to:x-mailer:mime-version
	:content-type:content-transfer-encoding;
	bh=2KWlA0RJav0X5DNL0VvgGj9sP/Pkov1p0AxaNvgZPug=;
	b=OcOROr4zekxwZXFb3YLq26+3sQw7ocuisAbOdFc3kifhRiB2qDp2d+r+FSUiOnGw8p
	cB/zN9weUVnx4MxW2YWqw3V5RXHXoEYEXcsv2WOW0zmQV5uY/YZhE1PFpssRxgdvl8pq
	vYifals20aKRdrlnTtreQuqMOEbvbnziakABg=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma;
	h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to
	:x-mailer:mime-version:content-type:content-transfer-encoding;
	b=kg0o8o/psFbEpSlPbmWS5GlupcIjl7ripfM3t4xra0vwGbPRdJXR0UbcfR8/0x1Oju
	xFeZ1lOAbF/ioJuYk+pOz8mUjtkWGTi6Mlg2sphJmr5h0tDmqai49gCwpSJtAneksjN3
	bOcvqriY6E6bVBpl9UbI8rCNNkpmc+U3jIR5I=
Received: by 10.204.117.204 with SMTP id s12mr778546bkq.60.1289069623801;
	Sat, 06 Nov 2010 11:53:43 -0700 (PDT)
Received: from ernst.jennejohn.org (p578E3053.dip.t-dialin.net [87.142.48.83])
	by mx.google.com with ESMTPS id 4sm2176086bki.1.2010.11.06.11.53.42
	(version=TLSv1/SSLv3 cipher=RC4-MD5);
	Sat, 06 Nov 2010 11:53:42 -0700 (PDT)
Date: Sat, 6 Nov 2010 19:53:40 +0100
From: Gary Jennejohn <gljennjohn@googlemail.com>
To: freebsd-hackers@freebsd.org
Message-ID: <20101106195340.23caa136@ernst.jennejohn.org>
In-Reply-To: <AANLkTimMt4Ucm+fRipzk3sq0M=1DNaC6EGQJ8M0ZWwob@mail.gmail.com>
References: <AANLkTimMt4Ucm+fRipzk3sq0M=1DNaC6EGQJ8M0ZWwob@mail.gmail.com>
X-Mailer: Claws Mail 3.7.6 (GTK+ 2.18.7; amd64-portbld-freebsd9.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Garrett Cooper <gcooper@FreeBSD.org>
Subject: Re: [PATCH] Simplify uart_bus_pci_probe
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: gljennjohn@googlemail.com
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 06 Nov 2010 19:17:03 -0000

On Sat, 6 Nov 2010 11:22:53 -0700
Garrett Cooper <gcooper@FreeBSD.org> wrote:

>     Some of the logic could have been simplified in the probe. The
> proposed patch makes the detection process a tad bit more
> straightforward.
>     Comments, review (and maybe a commit :P) are more than welcome :).
> Thanks!
> -Garrett

This is definitely much less convoluted and easier to understand than the
old code!

I'd commit it, if I still had my src commit bit :)

--
Gary Jennejohn