From nobody Wed May 8 11:30:37 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VZCcy3B1Wz5Kv0h; Wed, 08 May 2024 11:30:42 +0000 (UTC) (envelope-from mfechner@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VZCcy0lgxz4Fwx; Wed, 8 May 2024 11:30:42 +0000 (UTC) (envelope-from mfechner@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715167842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L2eTLi4yQkpNT5ohdkrii3JBz7t+FELI9lqKvPJ58ls=; b=nGiru3gk8v00eiP1/Rg7zvKe5k6/7wQrysVdai1+S7CoDtQ3Q8kB5SaxxR/v+/PdFAWHtq 4i8nAlu6WP52IgSHC4SQKMeD8oEO93uFbLMhBtMgzrohhauAsYO6MK/8OeJaDG2PKtKavo Lfss3x2/t2JDDByJ1032E9X0ULTeQEpPzNUCCi0wkASKqB25WsKrOS+NSGL6WDuMPw82kL cnsGsjuJwIndGl4J4ZrgFen+RJRagj//OcFDwVXXRf3NdSelS0RSbZboPrbsUK2/ZF+3xR VocLjQ5S8pP7s5CV3VXs3IAKzHJYL6o2GyvgGhRq4biqxdU2n370NV7uqZK3cA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1715167842; a=rsa-sha256; cv=none; b=pAw4LixYpPkhzGyoN69zHTS++rnjw2/YqR+d7WMJWnsArK5in5BMBSL7pxd5cTp4Wt8YGm e1y0c1GouVi8DbRiNcqQp2U0ArNYPtOFh49CicmfziW+x5i4t5EHNQJvA9cdwJvv/zdsjV GKyFrydXGjYfCbXLoVOK/GB0FbZdQKGQLEempGEZD+IGulsFBVrCuBMckSTaLp1L8e31Y0 mwtwjq94x4vnOKLVQVrF8Go1l8fZLcNbOOtLfEA2bY+JgHk2w50z6PKzSpE7vRRvKPnqbe 5dG8g+sO9z3cW23HECL/ORLBYXVpXwV/aCRf2zlEL88MTgbWD0So9QkD4j3p+w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715167842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L2eTLi4yQkpNT5ohdkrii3JBz7t+FELI9lqKvPJ58ls=; b=A/dIkh/kRo1IBQi5OyEwQtndPlSeNHQkNu+lkAtJB45l8dBLgCN6g2GBN+MHZ5olg4RI0D sk6QEzBi1dTmjXgeHEo7jxWb0ObcAkVZNLQbWYqVc48AGFiFtvNQaWobgMfrmebR2tpXYR OV7d2Osxpbbctf8upEXnik0agTZ2J4gV4TZeVpFsvxOiEx+ufbNnbr3KtOHHdEmse3lsEC 1kr/+mm62TMBrgDmDvVBruqyxbeZTZzltz517JDajzmteB0WpOj01VlprDH+U6Q+plId4X QNdF9oQ5W2Fq7vsXjn2XB/xsIR/qnaF0yRugS/1CYMsNJyFRCkV1fsyWTdcByw== Received: from [192.168.0.151] (unknown [212.108.150.210]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mfechner) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VZCcw5cRdz1CDx; Wed, 8 May 2024 11:30:40 +0000 (UTC) (envelope-from mfechner@freebsd.org) Content-Type: multipart/alternative; boundary="------------TIcp4J3101wzt8XevzHoQKIJ" Message-ID: <15d6dc83-d207-4c9c-b936-7408d9fa4d7e@freebsd.org> Date: Wed, 8 May 2024 14:30:37 +0300 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 6a6152fcf8c8 - main - textproc/rubygem-nokogiri: Do not install patches To: Antoine Brodin , Po-Chuan Hsieh Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202402211538.41LFcrlW090325@gitrepo.freebsd.org> Content-Language: en-US From: Matthias Fechner In-Reply-To: This is a multi-part message in MIME format. --------------TIcp4J3101wzt8XevzHoQKIJ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Am 06.05.2024 um 11:15 schrieb Antoine Brodin: > This is wrong: > > -- s.add_runtime_dependency(%q.freeze, ["~> 2.8.2"]) > > Now, nokogiri depends on mini_portile2 while it shouldn't according > to the comment in the Makefile would it maybe be possible to add mini_portile2 as a runtime dependency? Yes I know that it is maybe not required by FreeBSD, but it is listed upstream: https://rubygems.org/gems/nokogiri and that caused me already some problem that mini_portile2 was missing as some packages expected it (I do not remember the details, but it it took some time to find the reason why). If it does not break anything I suggest we keep as close on the upstream package and do not modify it if not absolutely necessary. Gruß Matthias -- "Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to produce bigger and better idiots. So far, the universe is winning." -- Rich Cook --------------TIcp4J3101wzt8XevzHoQKIJ Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
Am 06.05.2024 um 11:15 schrieb Antoine Brodin:
This is wrong:

--  s.add_runtime_dependency(%q<mini_portile2>.freeze, ["~> 2.8.2"])

Now,  nokogiri depends on mini_portile2 while it shouldn't according
to the comment in the Makefile

would it maybe be possible to add mini_portile2 as a runtime dependency?
Yes I know that it is maybe not required by FreeBSD, but it is listed upstream:
https://rubygems.org/gems/nokogiri

and that caused me already some problem that mini_portile2 was missing as some packages expected it (I do not remember the details, but it it took some time to find the reason why).

If it does not break anything I suggest we keep as close on the upstream package and do not modify it if not absolutely necessary.

Gruß
Matthias

-- 

"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs, and the universe trying to
produce bigger and better idiots. So far, the universe is winning." --
Rich Cook
--------------TIcp4J3101wzt8XevzHoQKIJ--