From owner-cvs-all@FreeBSD.ORG Thu Feb 26 19:13:15 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
by hub.freebsd.org (Postfix) with ESMTP
id A237616A4CE; Thu, 26 Feb 2004 19:13:15 -0800 (PST)
Received: from mta7.pltn13.pbi.net (mta7.pltn13.pbi.net [64.164.98.8])
by mx1.FreeBSD.org (Postfix) with ESMTP
id 811FA43D2F; Thu, 26 Feb 2004 19:13:15 -0800 (PST)
(envelope-from kris@obsecurity.org)
Received: from obsecurity.dyndns.org
(9b9b3efb617167f1f800aebb1468d020@adsl-67-119-53-203.dsl.lsan03.pacbell.net
[67.119.53.203])i1R3DDX0029225; Thu, 26 Feb 2004 19:13:13 -0800 (PST)
Received: by obsecurity.dyndns.org (Postfix, from userid 1000)
id 26DB766CAF; Thu, 26 Feb 2004 19:13:13 -0800 (PST)
Date: Thu, 26 Feb 2004 19:13:13 -0800
From: Kris Kennaway <kris@obsecurity.org>
To: Peter Schultz <pmes@bis.midco.net>
Message-ID: <20040227031312.GA11697@xor.obsecurity.org>
References: <200402251000.i1PA0nGn056196@repoman.freebsd.org>
<403E0B90.9040106@bis.midco.net> <20040226203351.GB5915@xor.obsecurity.org>
<403EA170.9080100@bis.midco.net> <20040227015101.GA10403@xor.obsecurity.org>
<403EAF98.7080009@bis.midco.net>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
protocol="application/pgp-signature"; boundary="sdtB3X0nJg68CQEu"
Content-Disposition: inline
In-Reply-To: <403EAF98.7080009@bis.midco.net>
User-Agent: Mutt/1.4.1i
cc: jkoshy@FreeBSD.org
cc: cvs-ports@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
cc: Kris Kennaway <kris@obsecurity.org>
Subject: Re: cvs commit: ports/graphics/xaos Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Feb 2004 03:13:15 -0000
--sdtB3X0nJg68CQEu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, Feb 26, 2004 at 08:46:48PM -0600, Peter Schultz wrote:
> >Set PTHREAD_LIBS=3D'-DNOP -lpthread' PTHREAD_CFLAGS=3D'-DNOP2' or similar
> >and verify that they're showing up correctly in the build log.
> >
>=20
> I'm not getting the point of this. If I `make -DWITH_THREADS' after=20
> this patch, xaos is built and linked properly:
>=20
> cc -DHAVE_SYS_PARAM_H -I/usr/local/include -pipe -O6 -fstrength-reduce=
=20
> -ffast-math -fomit-frame-pointer -fforce-mem -fforce-addr -funroll-loops=
=20
> -D_REENTRANT -I/usr/include/ncurses -I/usr/X11R6/include=20
> -I/usr/local/include -I/usr/X11R6/include=20
> -I/usr/ports/graphics/xaos/work/XaoS-3.0/src/include -L/usr/local/lib -o=
=20
> /usr/ports/graphics/xaos/work/XaoS-3.0/bin/xaos lib/libui.a=20
> lib/libengine.a lib/libutil.a lib/libfilter.a lib/libuiaa.a=20
> lib/libuix11.a -lpng -lz -lm -laa -lncurses -lpthread=20
> -L/usr/X11R6/lib -L/usr/X11R6/lib -lX11 -L/usr/X11R6/lib -lX11=20
> -L/usr/local/lib -L/usr/local/lib -lXext -L/usr/X11R6/lib -lX11
>=20
> What is -DNOP? Why doesn't textproc/libxml2 require this?
I mentioned -DNOP because it's a null operation that will have no
effect on the build, so you can easily verify from the build output
whether the port is using PTHREAD_CFLAGS and PTHREAD_LIBS for threaded
compilation and linking, or if it is hard-coding its own settings that
it thinks are correct for FreeBSD. It might happen to be choosing
values that correspond to the current default settings in FreeBSD, but
if a user wants to override those defaults, or if FreeBSD changes the
defaults again, then it will be wrong.
Many ports do not correctly use PTHREAD_{CFLAGS,LIBS}, but that's no
reason to add another incorrect one.
Kris
--sdtB3X0nJg68CQEu
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFAPrXIWry0BWjoQKURApKYAJ90vER5TfYUmONAB4m4LY+UBpqq/wCfdoX5
ull/YomwJG9d6sYgZBQVuv4=
=lKUc
-----END PGP SIGNATURE-----
--sdtB3X0nJg68CQEu--