From owner-freebsd-multimedia@FreeBSD.ORG Mon Apr 25 14:23:59 2011 Return-Path: Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DFB781065674 for ; Mon, 25 Apr 2011 14:23:58 +0000 (UTC) (envelope-from me@janh.de) Received: from mxchg03.rrz.uni-hamburg.de (mxchg03.rrz.uni-hamburg.de [134.100.38.113]) by mx1.freebsd.org (Postfix) with ESMTP id 723EA8FC1F for ; Mon, 25 Apr 2011 14:23:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mxchg03.rrz.uni-hamburg.de (Postfix) with ESMTP id 61F3A1EE3F9; Mon, 25 Apr 2011 16:23:57 +0200 (CEST) X-Virus-Scanned: by University of Hamburg ( RRZ / mgw02.rrz.uni-hamburg.de ) Received: from mxchg03.rrz.uni-hamburg.de ([127.0.0.1]) by localhost (mxchg03.rrz.uni-hamburg.de [127.0.0.1]) (amavisd-new, port 10324) with ESMTP id E57azSo7mxQ0; Mon, 25 Apr 2011 16:23:57 +0200 (CEST) Received: from mailhost.uni-hamburg.de (mailhost.uni-hamburg.de [134.100.32.155]) by mxchg03.rrz.uni-hamburg.de (Postfix) with ESMTPS; Mon, 25 Apr 2011 16:23:57 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mailhost.uni-hamburg.de (Postfix) with ESMTP id 4F53090003; Mon, 25 Apr 2011 16:23:57 +0200 (CEST) X-Virus-Scanned: by University of Hamburg (RRZ/mailhost) Received: from mailhost.uni-hamburg.de ([127.0.0.1]) by localhost (mailhost.uni-hamburg.de [127.0.0.1]) (amavisd-new, port 10024) with LMTP id qLdr1HJ0Cc3r; Mon, 25 Apr 2011 16:23:57 +0200 (CEST) Received: from nb981.math (f054010087.adsl.alicedsl.de [78.54.10.87]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: fmjv004) by mailhost.uni-hamburg.de (Postfix) with ESMTPSA id E7E3390002; Mon, 25 Apr 2011 16:23:56 +0200 (CEST) Message-ID: <4DB583F5.4090904@janh.de> Date: Mon, 25 Apr 2011 16:23:49 +0200 From: Jan Henrik Sylvester User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.15) Gecko/20110316 Thunderbird/3.1.9 MIME-Version: 1.0 To: Hans Petter Selasky References: <4DAB4E21.3070906@janh.de> <201104241047.57511.hselasky@c2i.net> <4DB4584D.3020104@janh.de> <201104242003.25569.hselasky@c2i.net> In-Reply-To: <201104242003.25569.hselasky@c2i.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: multimedia-list freebsd Subject: Re: webcamd regression 0.1.20->0.1.23: recv bulk message failed: -32 X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Apr 2011 14:23:59 -0000 On 04/24/2011 20:03, Hans Petter Selasky wrote: > On Sunday 24 April 2011 19:05:17 Jan Henrik Sylvester wrote: >> On 04/24/2011 10:47, Hans Petter Selasky wrote: >>> The V4L sources I've used might be a bit out of date. I've refreshed the >>> onces I have and uploaded a new tarball. >> >> Thanks, now your 0.1.25 tarball, which is still not working for me, and >> my 0.1.24 tarball from revision 1797, which is working for me, are much >> more similar. >> >> Besides the version number, the only difference is which files are >> contained. You got these files that I have not gotten in my tarball: >> >> cx24116.c >> dummy/compat.h.orig >> dummy/fcntl.h.orig > ^^ I've removed these files now. >> dvb-usb-urb.c >> stb0899_drv.c >> v4l2-dev.c > ^^^ can you send me the diff between your working and non-working tarball off- > list, and I will check it. The difference is really only which files are present and which are not. Your 0.1.25 tarball produces a webcamd that has my issue. Your 0.1.25 tarball with dvb-usb-urb.c deleted produces a webcamd that does not seem to have my issue. I have compared buildlogs and saw that the only difference is that in one case it is compiling v4l-dvb/linux/drivers/media/dvb/dvb-usb/dvb-usb-urb.c and in the other case is is compiling dvb-usb-urb.c (without the path). Looking at the difference of the two files, one has the zero pointer check in lines 45 to 46 while the other has the stability fix in lines 54 to 65. Thus, I created dvb-usb-urb.c with both or none of the fixes to see which is affecting me. For me, it does not matter, whether or not the zero pointer check is in dvb-usb-urb.c, but if the stability fix is in there, I have my issue, without the stability fix, I have no issue. Can the stability fix be removed or is there a way to correct the stability fix that it does not have these side effects for me? Thanks, Jan Henrik