Date: Tue, 13 Mar 2012 11:56:48 +0400 From: Pavel Timofeev <timp87@gmail.com> To: Ryan Stone <rysto32@gmail.com> Cc: "freebsd-scsi@freebsd.org" <freebsd-scsi@freebsd.org>, Sean Bruno <seanbru@yahoo-inc.com> Subject: Re: Can't load mps as module with custom kernel Message-ID: <CAAoTqfu7GiHhEPa_kUTXhniJZbvZ=CPRbH9EEY56=ABgU5xehA@mail.gmail.com> In-Reply-To: <CAFMmRNzTiMhLG9SXiZbY8z94iB7R9iMdGnqtNx5yhpOP2cWmig@mail.gmail.com> References: <20120305184313.GA3215@laptop.levsha.me> <20120307223959.GA39737@nargothrond.kdm.org> <1331188031232-5546565.post@n5.nabble.com> <1331228625.3075.11.camel@powernoodle-l7.corp.yahoo.com> <CAAoTqfvdzJzCCBbVYyaV0cx_j104CM2TEj7_MjPxYxS-%2BOwsWw@mail.gmail.com> <CAFMmRNzTiMhLG9SXiZbY8z94iB7R9iMdGnqtNx5yhpOP2cWmig@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
You're right, thank you!) It's OK now. Here is a new patch.
Do I need to create PR or write to this thread is enough?
13 марта 2012 г. 4:43 пользователь Ryan Stone <rysto32@gmail.com> написал:
> On Sun, Mar 11, 2012 at 6:13 AM, Pavel Timofeev <timp87@gmail.com> wrote:
>> link_elf_obj: symbol firmware_get undefined
>> KLD file isp.ko - could not finalize loading
>
> Hm, it seems that isp needs to MODULE_DEPEND on firmware, too:
>
> MODULE_DEPEND(isp, firmware, 1, 1, 1);
[-- Attachment #2 --]
--- /sys/dev/hptiop/hptiop.c 2012-03-12 12:03:51.000000000 +0400
+++ ./hptiop/hptiop.c 2012-03-11 13:14:49.000000000 +0400
@@ -1268,6 +1268,7 @@
};
DRIVER_MODULE(hptiop, pci, hptiop_pci_driver, hptiop_devclass, 0, 0);
+MODULE_DEPEND(hptiop, cam, 1, 1, 1);
static int hptiop_probe(device_t dev)
{
--- /sys/dev/hptmv/entry.c 2012-03-12 12:03:51.000000000 +0400
+++ ./hptmv/entry.c 2012-03-11 13:15:14.000000000 +0400
@@ -108,6 +108,7 @@
#define __DRIVER_MODULE(p1, p2, p3, p4, p5, p6) DRIVER_MODULE(p1, p2, p3, p4, p5, p6)
__DRIVER_MODULE(PROC_DIR_NAME, pci, hpt_pci_driver, hpt_devclass, 0, 0);
+MODULE_DEPEND(PROC_DIR_NAME, cam, 1, 1, 1);
#define ccb_ccb_ptr spriv_ptr0
#define ccb_adapter ccb_h.spriv_ptr1
--- /sys/dev/isp/isp_pci.c 2011-11-16 06:52:24.000000000 +0400
+++ ./isp/isp_pci.c 2012-03-13 11:28:28.000000000 +0400
@@ -372,6 +372,8 @@
};
static devclass_t isp_devclass;
DRIVER_MODULE(isp, pci, isp_pci_driver, isp_devclass, 0, 0);
+MODULE_DEPEND(isp, cam, 1, 1, 1);
+MODULE_DEPEND(isp, firmware, 1, 1, 1);
static int
isp_pci_probe(device_t dev)
--- /sys/dev/isp/isp_sbus.c 2011-02-15 00:50:51.000000000 +0300
+++ ./isp/isp_sbus.c 2012-03-13 11:28:43.000000000 +0400
@@ -106,6 +106,8 @@
};
static devclass_t isp_devclass;
DRIVER_MODULE(isp, sbus, isp_sbus_driver, isp_devclass, 0, 0);
+MODULE_DEPEND(isp, cam, 1, 1, 1);
+MODULE_DEPEND(isp, firmware, 1, 1, 1);
static int
isp_sbus_probe(device_t dev)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAAoTqfu7GiHhEPa_kUTXhniJZbvZ=CPRbH9EEY56=ABgU5xehA>