Date: Sat, 29 Aug 2015 12:05:34 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Babak Farrokhi <farrokhi@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r395548 - head/net/pathneck Message-ID: <20150829120534.GA89060@FreeBSD.org> In-Reply-To: <201508291148.t7TBmvHr073960@repo.freebsd.org> References: <201508291148.t7TBmvHr073960@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 29, 2015 at 11:48:57AM +0000, Babak Farrokhi wrote: > New Revision: 395548 > URL: https://svnweb.freebsd.org/changeset/ports/395548 > > Log: > net/patchneck: Makefile cleanup > - Remove dead MASTER_SITES > - Take maintainership > [...] > > PLIST_FILES= sbin/pathneck \ > sbin/get-choke > PORTDOCS= COPYING ChangeLog README > MAKEFILE= Makefile.bsd > +USES= tar:tgz USES is badly indented and misplaced (MAKEFILE knob is also misplaced). PLIST_FILES and PORTDOCS are package-related knobs, while USES are generic so they should typically be listed first after *_DEPENDS knobs. MAKEFILE is build-related so usually it's also expected to be found earlier. For a known license, you might also consider removing COPYING from PORTDOCS and use LICENSE framework instead. > OPTIONS_DEFINE= DOCS > > @@ -28,6 +27,8 @@ do-install: > ${INSTALL_PROGRAM} ${WRKSRC}/pathneck ${STAGEDIR}${PREFIX}/sbin/pathneck > ${INSTALL_PROGRAM} ${WRKSRC}/get-choke \ > ${STAGEDIR}${PREFIX}/sbin/get-choke Since destination file name is the same as source, it can be dropped. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150829120534.GA89060>