From owner-svn-ports-all@freebsd.org Fri Feb 19 22:55:20 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 118DBAAE11B; Fri, 19 Feb 2016 22:55:20 +0000 (UTC) (envelope-from ian@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D8E111886; Fri, 19 Feb 2016 22:55:19 +0000 (UTC) (envelope-from ian@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u1JMtIWw069634; Fri, 19 Feb 2016 22:55:18 GMT (envelope-from ian@FreeBSD.org) Received: (from ian@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u1JMtIbG069633; Fri, 19 Feb 2016 22:55:18 GMT (envelope-from ian@FreeBSD.org) Message-Id: <201602192255.u1JMtIbG069633@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: ian set sender to ian@FreeBSD.org using -f From: Ian Lepore Date: Fri, 19 Feb 2016 22:55:18 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r409214 - head/lang/lua53/files X-SVN-Group: ports-head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2016 22:55:20 -0000 Author: ian Date: Fri Feb 19 22:55:18 2016 New Revision: 409214 URL: https://svnweb.freebsd.org/changeset/ports/409214 Log: Fix CFLAGS handling in lua53 patches. The ?= assignment of CFLAGS (not present in earlier lua5x patches) results in MYCFLAGS, passed from the port makefile, never getting assigned to CFLAGS during the lua build. The result is a copy of lua that has none of the posix support functions in it. CFLAGS set in the outer environment by the user or make.conf get passed in via the MYCFLAGS mechanism, so remove the -O2 and let the outer environment control optimization level. Approved by: mat(mentor) Differential Revision: https://reviews.freebsd.org/D5256 Modified: head/lang/lua53/files/patch-src__Makefile Modified: head/lang/lua53/files/patch-src__Makefile ============================================================================== --- head/lang/lua53/files/patch-src__Makefile Fri Feb 19 22:51:22 2016 (r409213) +++ head/lang/lua53/files/patch-src__Makefile Fri Feb 19 22:55:18 2016 (r409214) @@ -7,7 +7,7 @@ -CC= gcc -std=gnu99 -CFLAGS= -O2 -Wall -Wextra -DLUA_COMPAT_5_2 $(SYSCFLAGS) $(MYCFLAGS) +CC?= gcc -std=gnu99 -+CFLAGS?= -O2 -Wall -Wextra -DLUA_COMPAT_5_2 $(SYSCFLAGS) $(MYCFLAGS) ++CFLAGS= -Wall -Wextra -DLUA_COMPAT_5_2 $(SYSCFLAGS) $(MYCFLAGS) LDFLAGS= $(SYSLDFLAGS) $(MYLDFLAGS) LIBS= -lm $(SYSLIBS) $(MYLIBS)