Date: Thu, 6 Aug 2020 13:34:50 +0100 From: =?UTF-8?Q?Danilo_Eg=C3=AAa_Gondolfo?= <danilo@freebsd.org> To: Mateusz Piotrowski <0mp@freebsd.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, ports-committers <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r544245 - head/x11/sakura Message-ID: <CAFU7VyPxZUg3z_if6aE0-2RHkKoMhr9dozk5xB=PVhn%2BX-Q86A@mail.gmail.com> In-Reply-To: <c30e03c9-1b8e-294b-c02c-14ada40f5d26@FreeBSD.org> References: <202008052155.075LtmtD072730@repo.freebsd.org> <20200806033440.GA53929@FreeBSD.org> <CAFU7VyOkoJ2yp6Oz88Tfkhts0GzVPDfKXJnyTbfJmmRS0QhcJw@mail.gmail.com> <c30e03c9-1b8e-294b-c02c-14ada40f5d26@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Aug 6, 2020 at 12:50 PM Mateusz Piotrowski <0mp@freebsd.org> wrote: > On 8/6/20 12:46 PM, Danilo Eg=C3=AAa Gondolfo wrote: > > On Thu, Aug 6, 2020 at 4:34 AM Alexey Dokuchaev <danfe@freebsd.org> > wrote: > > > >> On Wed, Aug 05, 2020 at 09:55:48PM +0000, Danilo Egea Gondolfo wrote: > >>> New Revision: 544245 > >>> URL: https://svnweb.freebsd.org/changeset/ports/544245 > >>> > >>> @@ -14,9 +14,10 @@ LICENSE=3D GPLv2 > >>> LIB_DEPENDS=3D libgnutls.so:security/gnutls \ > >>> libpcre2-8.so:devel/pcre2 > >>> > >>> +USES=3D cmake gnome pkgconfig gettext perl5 tar:bz2 x= org > >>> + > >>> OPTIONS_DEFINE=3D DOCS > >>> > >>> -USES=3D cmake gnome pkgconfig gettext perl5 xorg > >>> USE_GNOME=3D cairo gdkpixbuf2 vte3 > >> I'd argue that USES was placed better before this change (right next t= o > >> USE_FOO knobs). It should've been left where it was and OPTIONS_DEFIN= E > >> moved downwards instead. > >> > >> ./danfe > >> > > Just tried to make portlint happy on this one ("USES should appear > > earlier"). > > Please try portfmt and portclippy from ports-mgmt/portfmt. They are much > better for order fixes and > simple style fixes than portlint in most cases. > > Cheers, > > Mateusz Piotrowski > > Interesting, I'll give it a try. Thanks ;)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFU7VyPxZUg3z_if6aE0-2RHkKoMhr9dozk5xB=PVhn%2BX-Q86A>