Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 22 Mar 2004 11:45:16 +0300
From:      goblin <goblin@nnt.ru>
To:        joseph@randomnetworks.com
Cc:        ports@FreeBSD.org
Subject:   FreeBSD Port: swatch-3.0.8
Message-ID:  <55336504798.20040322114516@nnt.ru>

next in thread | raw e-mail | index | archive | help
------------481CC1F016E0A5D2
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Hello joseph,

at first, sorry for my poor english, but i hope
you can understand me :)

i have some problems using this program, and fixed it,
but it is a little boring to patch swatch on each cvsup %(
so i ask you to apply my patch to this port plz
(current patch is for swatch-3.0.8_1)

here are the problems:

1. using sendmail program
here is swatch.conf example
----------------
watchfor /blin/
        echo
        mail addresses=goblin\@nnt.ru
----------------
it sends mail on first occurence of blin, but then it hangs
in wait() state, waiting while sendmail process is finished
(while it is already died)
patch is to add

local $SIG{CHLD} = 'default';
before open(SENDMAIL, "| /usr/sbin/sendmail...")
so wait() returns successfully on sendmail's exit

2.
while using tail cmd, it does not like any signals,
so on kill -HUP <swatch.pl pid>, it sends SIGTERM
to child .swatch.pid process, but
in function goodbye() it hangs on exit(0),
because /usr/bin/tail still works...

patch is to start /usr/bin/tail not like
open (TAIL, "/usr/bin/tail |")

but fork-exec with saving child pid and kill TAIL process in
goodbye

all works fine (kill -1 <swatch pid, .swatch.pid pid>)

3. and, may be, it is useful to start tail with not -n 1,
but -n 0, but it is ... as you wish

-- 
Best regards,
 goblin                          mailto:goblin@nnt.ru
------------481CC1F016E0A5D2
Content-Type: application/octet-stream; name="swatch.sendmail.and.tail.patch"
Content-transfer-encoding: base64
Content-Disposition: attachment; filename="swatch.sendmail.and.tail.patch"

LS0tIHN3YXRjaC5vcmlnCU1vbiBNYXIgMjIgMDg6NDk6NTkgMjAwNAorKysgc3dhdGNoCU1v
biBNYXIgMjIgMTE6MjA6MTAgMjAwNApAQCAtMzU1LDcgKzM1NSw3IEBACiBteSAkQlVJTERf
REFURSA9ICI0IEFwcmlsIDIwMDMiOwogCiBteSAkdGFpbF9jbWRfbmFtZSA9ICcnOyAjIFdl
J2xsIHRyeSB0byBmaW5kIGl0IGluIHRoZSBQQVRIIGxhdGVyCi1teSAkdGFpbF9wcm9ncmFt
X2FyZ3MgPSAnLW4gMSAtZic7ICAKK215ICR0YWlsX3Byb2dyYW1fYXJncyA9ICctbiAwIC1m
JzsKIAogIyMjIyMjIyB1c2VfYW5kX3ZhcmlhYmxlcyBlbmQgIyMjIyMjIwogIyMjIyMjIyBw
cmludF92ZXJzaW9uIGJlZ2luICMjIyMjIyMKQEAgLTY0OCw2ICs2NDgsNyBAQAogbXkgXCRN
QUlMRVIgPSAiJG1haWxfY21kIjsKIG15IFwkV1JJVEUgID0gIiR3cml0ZV9jbWQiOwogXCQv
ID0gIiRvcHRfaW5wdXRfcmVjb3JkX3NlcGFyYXRvciI7CitteSBcJHRhaWxfcGlkID0gMDsJ
IyB1c2VkIHRvIGtpbGwgVEFJTGVkIHByb2Nlc3MKIAogdXNlIElPOjpIYW5kbGU7CiBTVERP
VVQtPmF1dG9mbHVzaCgxKTs7CkBAIC02NjQsNiArNjY1LDcgQEAKIAogICAkY29kZSAuPSBx
fAogICBjbG9zZV9waXBlX2lmX29wZW4oKTsKKyAga2lsbCgnVEVSTScsICR0YWlsX3BpZCkg
aWYgJHRhaWxfcGlkOyAjIG9yIGV4aXQoMCkgd2lsbCBoYW5nIGluIHdhaXQoKSBzdGF0ZSB0
aWxsIC90YWlsIHdvcmtzCiAgIGV4aXQoMCk7CiB9CiAKQEAgLTkzMiw2ICs5MzQsOSBAQAog
CiAgIChteSAkdG9fbGluZSA9ICRhcmdzeydBRERSRVNTRVMnfSkgPX4gcy86LywvZzsKIAor
ICAjIHBpcGVkIG9wZW4gY2FsbHMgd2FpdCgpIHRvIGNhdGNoIFNJR0NITEQgd2hlbiBjaGls
ZCBwcm9jZXNzIGlzIGZpbmlzaGVkCisgICMgaWYgJFNJR3tDSExEfSA9PSAnSUdOT1JFJywg
dGhlbiBpdCBoYW5ncyBmb3JldmVyLi4uCisgIGxvY2FsICRTSUd7Q0hMRH0gPSAnZGVmYXVs
dCc7CiAgIG9wZW4oTUFJTCwgInwgJE1BSUxFUiIpCiAgICAgb3Igd2FybiAiJDA6IGNhbm5v
dCBvcGVuIHBpcGUgdG8gJE1BSUxFUjogJCFcbiIgJiYgcmV0dXJuOwogCkBAIC0xMTkwLDkg
KzExOTUsMjMgQEAKICAgICAgIH0KICAgICAgICAkY29kZSA9IHFxLwogbXkgXCRmaWxlbmFt
ZSA9ICckZmlsZW5hbWUnOwotaWYgKG5vdCBvcGVuKFRBSUwsIFwiJHRhaWxfY21kX25hbWUg
JHRhaWxfcHJvZ3JhbV9hcmdzIFwkZmlsZW5hbWV8XCIpKSB7Ci0gICAgZGllICIkMDogY2Fu
bm90IHJlYWQgcnVuIFxcIiR0YWlsX2NtZF9uYW1lICR0YWlsX3Byb2dyYW1fYXJncyBcJGZp
bGVuYW1lXFwiOiBcJCFcXG4iOwotfQorCisjIHVzZSB0aGlzIGJsb2NrIGluc3RlYWQgb2Yg
YmVsb3cgY29tbWVudGVkCitwaXBlIFRBSUwsIEZEVzsKK1wkdGFpbF9waWQgPSBmb3JrOwor
aWYoIVwkdGFpbF9waWQpIHsKKwljbG9zZSBTVERPVVQ7CisJb3BlbiBTVERPVVQsIFwiPlwm
RkRXXCI7CisJY2xvc2UgVEFJTDsKKwlleGVjIFwiJHRhaWxfY21kX25hbWUgJHRhaWxfcHJv
Z3JhbV9hcmdzIFwkZmlsZW5hbWVcIgorCQlvciBkaWUgXCIkMDogY2Fubm90IGV4ZWMgXFwi
JHRhaWxfY21kX25hbWUgJHRhaWxfcHJvZ3JhbV9hcmdzIFwkZmlsZW5hbWVcXCI6IFwkIVxc
blwiOworCVBPU0lYOjpfZXhpdCgwKTsKK30KK2Nsb3NlIEZEVzsKKworI2lmIChub3Qgb3Bl
bihUQUlMLCBcIiR0YWlsX2NtZF9uYW1lICR0YWlsX3Byb2dyYW1fYXJncyBcJGZpbGVuYW1l
fFwiKSkgeworIyAgICBkaWUgIiQwOiBjYW5ub3QgcmVhZCBydW4gXFwiJHRhaWxfY21kX25h
bWUgJHRhaWxfcHJvZ3JhbV9hcmdzIFwkZmlsZW5hbWVcXCI6IFwkIVxcbiI7CisjfQogCiBM
T09QOiB3aGlsZSAoPFRBSUw+KSB7CiAvOwo=

------------481CC1F016E0A5D2--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55336504798.20040322114516>