Date: Thu, 27 Apr 2017 16:46:27 +0000 From: "Sergey A. Osokin" <osa@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r439421 - in head/www/nginx: . files Message-ID: <20170427164627.GE18747@FreeBSD.org> In-Reply-To: <1426aa14-e30f-bb33-6e76-5fdfdd222e74@FreeBSD.org> References: <201704252318.v3PNI9Io032993@repo.freebsd.org> <b836e2e3-8920-538a-a87e-f7a931f1a85f@FreeBSD.org> <20170426165333.GC18747@FreeBSD.org> <1426aa14-e30f-bb33-6e76-5fdfdd222e74@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 27, 2017 at 08:24:55AM +0200, Mathieu Arnold wrote: > Le 26/04/2017 ?? 18:53, Sergey A. Osokin a ??crit : > > On Wed, Apr 26, 2017 at 06:18:44PM +0200, Mathieu Arnold wrote: > >> Le 26/04/2017 ?? 01:18, Sergey A. Osokin a ??crit : > >>> Author: osa > >>> Date: Tue Apr 25 23:18:09 2017 > >>> New Revision: 439421 > >>> URL: https://svnweb.freebsd.org/changeset/ports/439421 > >>> > >>> Log: > >>> Upgrade from 1.10.3 to 1.12.0. > >>> =20 > >>> ChangeLog: http://nginx.org/en/CHANGES-1.12 > >>> =20 > >>> Remove IPV6 knob, IPv6 now compiled-in automatically if support is = found. > >> This still feels like a very bad idea. > > Could you please explain what exactly is very bad here? >=20 > We had that talk like a week or two ago. It means that if the package > builder support IPv6 it will not work on a box without it, and if the > package builder does not support IPv6, a box with IPv6 will not be able > to use nginx with IPv6. Then you can go ahead and enable IPv6 on the package builder like you did t= he same for the third-party moz_zip module. INET6 in FreeBSD's GENERIC kernel for years, I see no reason why shouldn't = use it. > >>> Also, remove third-party modules: > >>> o) udplog > >>> o) statsd > >>> =20 > >>> Enable third_party mod_zip module back by changing upstream. > >>> =20 > >> I think this is what breaks the build: > >> > >> https://pkg.absolight.fr/data/11amd64-pkgng-default/20170426T181224Z/l= ogs/errors/nginx-1.12.0,2.log > >> > >> cc -c -I/usr/local/include/luajit-2.0 -O2 -pipe -DLIBICONV_PLUG -fsta= ck-protector -fno-strict-aliasing -I /usr/local/include -DNDK_SET_VAR -Wno-= write-strings -DNDK_SET_VAR -I src/core -I src/event -I src/event/module= s -I src/os/unix -I /wrkdirs/usr/ports/www/nginx/work/nginx-push-stream-m= odule-0.5.1/src -I /wrkdirs/usr/ports/www/nginx/work/nginx-push-stream-mod= ule-0.5.1/include -I /wrkdirs/usr/ports/www/nginx/work/ngx_devel_kit-0.3.0= /objs -I objs/addon/ndk -I /wrkdirs/usr/ports/www/nginx/work/lua-nginx-mo= dule-0.10.8/src/api -I /usr/local/include/libxml2 -I /usr/local/include = -I objs -I src/http -I src/http/modules -I src/http/v2 -I src/http/modu= les/perl -I /wrkdirs/usr/ports/www/nginx/work/nchan-0.99.16/src -I /wrkdi= rs/usr/ports/www/nginx/work/ngx_devel_kit-0.3.0/src -I /wrkdirs/usr/ports/= www/nginx/work/ngx_devel_kit-0.3.0/src -I /wrkdirs/usr/ports/www/nginx/wor= k/ngx_devel_kit-0.3.0/objs -I objs/addon/ndk -I /usr/local/include/luajit= -2.0 -I /wrkdirs/usr/ports/www/nginx/work/njs-753ebe6/nginx/../nxt -I /wr= kdirs/usr/ports/www/nginx/work/njs-753ebe6/nginx/../njs -I src/mail -I sr= c/stream -I /wrkdirs/usr/ports/www/nginx/work/njs-753ebe6/nginx/../nxt -I= /wrkdirs/usr/ports/www/nginx/work/njs-753ebe6/nginx/../njs -o objs/addon/= mod_zip-74ef235/ngx_http_zip_module.o /wrkdirs/usr/ports/www/nginx/work/mo= d_zip-74ef235/ngx_http_zip_module.c > >> /wrkdirs/usr/ports/www/nginx/work/mod_zip-74ef235/ngx_http_zip_module.= c:74:4: error: no member named 'charset' in '' > >> offsetof(ngx_http_zip_conf_t, charset), > >> ^ ~~~~~~~ > >> /usr/include/stddef.h:65:32: note: expanded from macro 'offsetof' > >> #define offsetof(type, member) __offsetof(type, member) > >> ^ ~~~~~~ > >> /usr/include/sys/cdefs.h:477:34: note: expanded from macro '__offsetof' > >> #define __offsetof(type, field) __builtin_offsetof(type, field) > >> ^ ~~~~~ > >> 1 error generated. > >> *** Error code 1 > > Need an explanation here why third-party mod_zip module has been enable= d, cause by > > default all third-party modules should be switched off. >=20 > Because it was enabled by someone, me, for instance ? Would you mind to raise a PR for the same, thanks. In any case I can't reproduce it here on my FreeBSD 11.0-STABLE amd64. --=20 Sergey Osokin osa@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170427164627.GE18747>