Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 29 Sep 2023 17:23:35 +0100
From:      Jessica Clarke <jrtc27@freebsd.org>
To:        Ed Maste <emaste@FreeBSD.org>
Cc:        "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org>, Jose Luis Duran <jlduran@gmail.com>
Subject:   Re: git: f147cf0ee2b2 - main - dtc: Ensure it is built in C++17 mode
Message-ID:  <DEC36812-E58F-4792-BE89-472E63E328E7@freebsd.org>
In-Reply-To: <202309291327.38TDR4I3067177@gitrepo.freebsd.org>
References:  <202309291327.38TDR4I3067177@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 29 Sep 2023, at 14:27, Ed Maste <emaste@FreeBSD.org> wrote:
>=20
> The branch main has been updated by emaste:
>=20
> URL: =
https://cgit.FreeBSD.org/src/commit/?id=3Df147cf0ee2b2642c0a133a71c8a5dc01=
8518d923
>=20
> commit f147cf0ee2b2642c0a133a71c8a5dc018518d923
> Author:     Jose Luis Duran <jlduran@gmail.com>
> AuthorDate: 2023-09-29 13:24:32 +0000
> Commit:     Ed Maste <emaste@FreeBSD.org>
> CommitDate: 2023-09-29 13:26:51 +0000
>=20
>    dtc: Ensure it is built in C++17 mode
>=20
>    Explicitly specify the C++ standard to be used in the Makefile.
>    This prevents macOS cross-builds from using the default gnu++98 and
>    fail.  This syncs dtc with upstream commit
>    39a58cfaab7d55c7975ebf905d859ba91a369fa0.

Thank you.

Jess

>    Reviewed by: emaste
>    Fixes: 29a55fd09b0a ("dtc: Sync with upstream commit 26a0fe5")
>    Differential Revision: https://reviews.freebsd.org/D42006
> ---
> usr.bin/dtc/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>=20
> diff --git a/usr.bin/dtc/Makefile b/usr.bin/dtc/Makefile
> index d7661ae164c3..9b1aff13511f 100644
> --- a/usr.bin/dtc/Makefile
> +++ b/usr.bin/dtc/Makefile
> @@ -6,6 +6,8 @@ WARNS?=3D 3
>=20
> CXXFLAGS+=3D -fno-rtti -fno-exceptions
>=20
> +CXXSTD=3D c++17
> +
> NO_SHARED?=3DNO
>=20
> .include <bsd.prog.mk>




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DEC36812-E58F-4792-BE89-472E63E328E7>