From nobody Wed Jul 19 13:40:03 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4R5cQB0Bb4z4nyHN for ; Wed, 19 Jul 2023 13:40:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4R5cPv5Sx8z4JZY for ; Wed, 19 Jul 2023 13:40:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1689774003; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8VhGjaZuyU1JCGY1hcQ89C7ZvWDtLlf3h6q/966rPy0=; b=rpMXHTrSOtn9aN97ve6qgAGIUXIseAx+VNGB19gflb/fpgvjAudohO1Vo2jXyCK1XkZQZ3 jOmm9QkRCBGtJuNIApYnP92oEcllM0BbmM/KP7TcnY0nJ9U4njLorOICeAgxvyX/ceRIm7 mSMBQH9e/BGqvWNm1RGILH79U8896fymPMP6w1si9Yrg+XvrSItzYO12rKytLN8a8K1/U1 Byt3HII+kDbjiPajyOY/dKHQXkADa/ZzCodIu7n/h3Hg5ZobTf/I4+wkse120anhaidO78 KQWVEUTYTNEKH4bhjsqN4XdtkhrANhHPKVioI8dfHveexkDvo9DV0+ZTkE1Bmw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1689774003; a=rsa-sha256; cv=none; b=Ot1k1jcJGcBcz2QXHk9EAg/9B/LMZOOlxDA23c1yTbiCHuVzjCmDBizlbY63511KoKlesF 3gf7yvyKANgBBMK0o0JfrfmIkFjCrH/hoDXW2mCKjhPTcoSdM0594vA2HNUn0f5zCUKa49 hHOpOSstaXR8z69IcysBjrBKry3UvFrKyeQyiCGgWNibQDxZ6qQTCmUacOpnI4BY1598pc TvU3z7JpcGp3+VXEuy+DN+ockVVJiju6VxVfxawgdkPnUksUzsNa8yM3fKTi3akVmB70iR eeqVpSuEj8YFkvpfueypuiZMP1vthWwFbrScvmT9QSiQfPzlqz3RgAKOX4AUEg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4R5cPv49MNzpdm for ; Wed, 19 Jul 2023 13:40:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 36JDe3OB004939 for ; Wed, 19 Jul 2023 13:40:03 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 36JDe3GP004938 for bugs@FreeBSD.org; Wed, 19 Jul 2023 13:40:03 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 238995] adduser does not check for pre-existing user field entries in /etc/group Date: Wed, 19 Jul 2023 13:40:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238995 --- Comment #4 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D17839f45d86e79065a65ad3e2522dd69b= 29a652c commit 17839f45d86e79065a65ad3e2522dd69b29a652c Author: Naman Sood AuthorDate: 2023-07-19 12:44:21 +0000 Commit: Joseph Mingrone CommitDate: 2023-07-19 13:36:09 +0000 pw: Ensure group membership is not duplicated Fix the following problem: 1. A nonexistent user, someuser, is added to somegroup in /etc/group. 2. someuser is then created with membership in somegroup. The entry for somegroup in /etc/group will then contain somegroup:*:12345:someuser,someuser With this fix, the entry will be somegroup:*:12345:someuser PR: 238995 Reviewed by: bapt, jrm Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D41076 usr.sbin/pw/pw.h | 2 ++ usr.sbin/pw/pw_group.c | 2 +- usr.sbin/pw/pw_user.c | 3 +++ 3 files changed, 6 insertions(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.=