From owner-svn-src-head@FreeBSD.ORG Wed Jul 9 23:43:18 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 04EA055C; Wed, 9 Jul 2014 23:43:18 +0000 (UTC) Received: from mail-qg0-x22b.google.com (mail-qg0-x22b.google.com [IPv6:2607:f8b0:400d:c04::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6417C27AB; Wed, 9 Jul 2014 23:43:17 +0000 (UTC) Received: by mail-qg0-f43.google.com with SMTP id z60so6844717qgd.16 for ; Wed, 09 Jul 2014 16:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=6S4fQl2CGNCOsknmr6rzvLckVcbfIXqQH+ckstxWUas=; b=I1r39OcMh98cuAa6IbmNWgYZ66dlcfR2SyvxZfLKZ/3fsgSgtMrW3YvVhT4i/0eKMX y6GAMGBp4vnpoOiMqhEyVGopltG9SE1HRj7Ik4mop+il4sfX5fgrOKQOaqCFXR0gMW/g 34+524H+LmMm7JCrwsyeHjrd/wlld0Xugx4dX849xbhMKoOGEdbnwHK2GAVEWc3sFWH+ ti8Y/jlTX9WAINhNCqSPeDlTjTj88+c7UgA7pNXQA49YY+8WhvPGgPss9I2CGfN/pvjc fJyzbkPv9xyj62++EpcBybiC0eZ7fcFyfxlAiIh5rRVl6pPBwqBBSLsLtcoL4zASa3IN ktSA== MIME-Version: 1.0 X-Received: by 10.224.130.201 with SMTP id u9mr74342785qas.98.1404949396633; Wed, 09 Jul 2014 16:43:16 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.224.202.193 with HTTP; Wed, 9 Jul 2014 16:43:16 -0700 (PDT) In-Reply-To: <20140709232536.GF56040@ivaldir.etoilebsd.net> References: <201407091552.s69FqUon070685@svn.freebsd.org> <53BD68E4.1070706@freebsd.org> <20140709172305.GD56040@ivaldir.etoilebsd.net> <20140709232536.GF56040@ivaldir.etoilebsd.net> Date: Wed, 9 Jul 2014 16:43:16 -0700 X-Google-Sender-Auth: Lf7gMeHv1yrZe_GDsP-DCaCU6FM Message-ID: Subject: Re: svn commit: r268461 - in head: . gnu/lib/libreadline gnu/lib/libreadline/history gnu/lib/libreadline/readline gnu/lib/libreadline/readline/doc gnu/usr.bin/gdb gnu/usr.bin/gdb/gdb gnu/usr.bin/gdb/gd... From: Adrian Chadd To: Baptiste Daroussin Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , Pedro Giffuni , "src-committers@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jul 2014 23:43:18 -0000 Sounds good. :) -a On 9 July 2014 16:25, Baptiste Daroussin wrote: > On Wed, Jul 09, 2014 at 11:05:29AM -0700, Adrian Chadd wrote: >> On 9 July 2014 10:23, Baptiste Daroussin wrote: >> > On Wed, Jul 09, 2014 at 10:12:27AM -0700, Adrian Chadd wrote: >> >> Hi, >> >> >> >> By doing this you're actually making more work for the really embedded >> >> people who have size constraints on things. >> >> >> >> I dislike privatelib but it at least allows for code sharing where >> >> before people would just statically link things into binaries. >> > >> > do you install gdb on your embedded environnement? because that is the only >> > user of libreadline. >> >> See below. >> >> >> >> >> I've had to actively undo this kind of dumb before in order to get >> >> things to fit on very small flash root filesystems. >> >> >> >> Shared libraries are good. Please stop assuming we have lots of disk >> >> space and RAM to have duplicates of things floating around. >> > >> > Facts: >> > Before >> > gdb + kgdb + gdbtui + libreadline.so.8 + libhistory.so.8 = 8976 k >> > After >> > gdb + kgdb + gdbtui = 8973 k >> > >> > I don't think I have damaged too much your embedded system am I wrong? >> > >> > Do I miss something? >> > >> > (Yes I have checked that before turning into an internallib given my first >> > approach was to turn into a privatelib. >> >> Sure, except for the people who have done things like rolled local >> configuration/management telnet interfaces for these things. They're >> also using libreadline (and things like the cisco UI library.) >> >> And yeah, I do install gdb in there from time to time. Code sometimes >> needs debugging. :-) >> > They can in that case use libedit which exports a libreadline compatibility > interface in the base system (it is working well with the known cisco-like UI > things ;) so even in that case I save them space given libedit is required for > /bin/sh (the only known problem can happen if the are using unicode and from my > last test the cisco UI thing is not unicode friendly either so that should make > no difference here for them). > > The other thing is there are a couple of ABI incompatibilities between the > libreadline version we have in base and newer libreadline which is getting more > and more use making it more complicated to manage ports that requires newer > readline. > > regards, > Bapt