Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 2 Jul 2012 09:32:43 -0700
From:      Marcel Moolenaar <marcel@xcllnt.net>
To:        Baptiste Daroussin <bapt@FreeBSD.org>, Dag-Erling Sm?rgrav <des@des.no>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn commit: r237997 - in head: tools/build/mk tools/build/options usr.sbin
Message-ID:  <2B78C1CB-FC64-4C78-94D1-B01F02C02D2D@xcllnt.net>
In-Reply-To: <201207021528.q62FSoot078093@svn.freebsd.org>
References:  <201207021528.q62FSoot078093@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On Jul 2, 2012, at 8:28 AM, Baptiste Daroussin wrote:

> Author: bapt
> Date: Mon Jul  2 15:28:50 2012
> New Revision: 237997
> URL: http://svn.freebsd.org/changeset/base/237997
>=20
> Log:
>  New build KNOB: WITHOUT_PKGBOOTSTRAP to condition building of =
usr.sbin/pkg
>  Do not condition usr.sbin/pkg building on WITHOUT_PKGTOOLS anymore, =
so that users can
>  remove the old pkg_* tools without removing the pkgng boostrap

Oh, and:

> Added: head/tools/build/options/WITHOUT_PKGBOOSTRAP

You have a typo in the options filename as well.

With all those mistakes and typos, I cannot escape the notion that this =
is a
rushed commit or at least that it didn't get the attention it should =
have
gotten. Worse, it wasn't caught by your mentor.

des: please give reviews more attention
bapt: it sometimes helps to review your own patches as if they weren't =
yours.
      you won't catch as much as a real 3rd party would, because they =
are
      still your patches and you're bound to overlook stuff, but at =
least
      you may catch some of the boneheaded stuff.

HTH,

--=20
Marcel Moolenaar
marcel@xcllnt.net





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2B78C1CB-FC64-4C78-94D1-B01F02C02D2D>