From owner-svn-src-head@FreeBSD.ORG  Mon Jul  2 16:32:47 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A280C1065799;
	Mon,  2 Jul 2012 16:32:47 +0000 (UTC)
	(envelope-from marcel@xcllnt.net)
Received: from mail.xcllnt.net (mail.xcllnt.net [70.36.220.4])
	by mx1.freebsd.org (Postfix) with ESMTP id 7F5108FC18;
	Mon,  2 Jul 2012 16:32:47 +0000 (UTC)
Received: from sa-nc-common-101.static.jnpr.net (natint3.juniper.net
	[66.129.224.36]) (authenticated bits=0)
	by mail.xcllnt.net (8.14.5/8.14.5) with ESMTP id q62GWc3Y005021
	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO);
	Mon, 2 Jul 2012 09:32:45 -0700 (PDT)
	(envelope-from marcel@xcllnt.net)
Mime-Version: 1.0 (Apple Message framework v1278)
Content-Type: text/plain; charset=us-ascii
From: Marcel Moolenaar <marcel@xcllnt.net>
In-Reply-To: <201207021528.q62FSoot078093@svn.freebsd.org>
Date: Mon, 2 Jul 2012 09:32:43 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <2B78C1CB-FC64-4C78-94D1-B01F02C02D2D@xcllnt.net>
References: <201207021528.q62FSoot078093@svn.freebsd.org>
To: Baptiste Daroussin <bapt@FreeBSD.org>, Dag-Erling Sm?rgrav <des@des.no>
X-Mailer: Apple Mail (2.1278)
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r237997 - in head: tools/build/mk
	tools/build/options usr.sbin
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Jul 2012 16:32:47 -0000


On Jul 2, 2012, at 8:28 AM, Baptiste Daroussin wrote:

> Author: bapt
> Date: Mon Jul  2 15:28:50 2012
> New Revision: 237997
> URL: http://svn.freebsd.org/changeset/base/237997
>=20
> Log:
>  New build KNOB: WITHOUT_PKGBOOTSTRAP to condition building of =
usr.sbin/pkg
>  Do not condition usr.sbin/pkg building on WITHOUT_PKGTOOLS anymore, =
so that users can
>  remove the old pkg_* tools without removing the pkgng boostrap

Oh, and:

> Added: head/tools/build/options/WITHOUT_PKGBOOSTRAP

You have a typo in the options filename as well.

With all those mistakes and typos, I cannot escape the notion that this =
is a
rushed commit or at least that it didn't get the attention it should =
have
gotten. Worse, it wasn't caught by your mentor.

des: please give reviews more attention
bapt: it sometimes helps to review your own patches as if they weren't =
yours.
      you won't catch as much as a real 3rd party would, because they =
are
      still your patches and you're bound to overlook stuff, but at =
least
      you may catch some of the boneheaded stuff.

HTH,

--=20
Marcel Moolenaar
marcel@xcllnt.net