From owner-freebsd-ports@FreeBSD.ORG  Wed Jun 22 13:20:16 2011
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 25657106564A;
	Wed, 22 Jun 2011 13:20:16 +0000 (UTC)
	(envelope-from itetcu@FreeBSD.org)
Received: from worf.ds9.tecnik93.com (worf.ds9.tecnik93.com [81.196.207.130])
	by mx1.freebsd.org (Postfix) with ESMTP id D49AE8FC15;
	Wed, 22 Jun 2011 13:20:14 +0000 (UTC)
Received: from User-PC (unknown [81.181.146.246])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by worf.ds9.tecnik93.com (Postfix) with ESMTPSA id BDC4C22C55D1;
	Wed, 22 Jun 2011 16:02:35 +0300 (EEST)
Date: Wed, 22 Jun 2011 16:02:33 +0300
From: Ion-Mihai Tetcu <itetcu@FreeBSD.org>
To: Chris Rees <crees@freebsd.org>
Message-Id: <20110622160233.8b6156e1.itetcu@FreeBSD.org>
In-Reply-To: <BANLkTi=s6zYOJJv6+kk+ttd7jadmTuaT6w@mail.gmail.com>
References: <20110621214013.6cc4760e@heavennet.ru>
	<20110622020048.GA83940@FreeBSD.org>
	<BANLkTi=En+7nJgEmKCmBEQMwiV0nbcPhEg@mail.gmail.com>
	<20110622064224.GB94185@FreeBSD.org>
	<BANLkTi=s6zYOJJv6+kk+ttd7jadmTuaT6w@mail.gmail.com>
X-Mailer: Sylpheed 3.1.1 (GTK+ 2.10.14; i686-pc-mingw32)
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: quoted-printable
Cc: ports@freebsd.org, "Ilya A. Arkhipov" <micro@heavennet.ru>,
	Alexey Dokuchaev <danfe@freebsd.org>, kwm@freebsd.org
Subject: Re: OpenTTD
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Jun 2011 13:20:16 -0000

On Wed, 22 Jun 2011 09:56:55 +0100
Chris Rees <crees@freebsd.org> wrote:

> 2011/6/22 Alexey Dokuchaev <danfe@freebsd.org>:
> > On Wed, Jun 22, 2011 at 10:33:14AM +0400, Ilya A. Arkhipov wrote:
> >> Ok i rewrite patch and do with argument, and write patch to portlint ;)
> >
> > Wow, if you could write a patch to portlint that is would correctly sug=
gest
> > that MAINTAINER/COMMENT/LICENSE should be grouped together, and FOO_DEP=
ENDS
> > would be closed to USE_BAR knobs, I'd be very grateful!
> >
> > Just to make myself clear on this issue: COMMENT/LICENSE are general
> > software information, FOO_DEPENDS and USE_BAR knobs both specify
> > dependencies (that is, package-related stuff). =A0I believe that it doe=
s not
> > make sence to mix them, hence LICENSE should be defined before _DEPENDS=
, not
> > after.
> >
>=20
> I agree 110% with this. It confused me a while ago when I started to
> use LICENSE, but I think the general acceptance is that we should
> have:
>=20
> PORTNAME
> PORTVERSION
> etc
>=20
> MAINTAINER
> COMMENT
>=20
> LICENSE
>=20
> So license in a separate block; you can have several license lines
> making the MAINTAINER/COMMENT block unnecessarily large.
>=20
> Not too sure about keeping _DEPENDS with USE; there're additional
> variables often set with USE, perhaps a block for _DEPENDS and then
> USE etc underneath? (could follow with USERS/GROUPS).
>=20
> Example:
>=20
> PORTNAME
> PORTVERSION
> etc
>=20
> MAINTAINER
> COMMENT
>=20
> LICENSE
>=20
> LIB_DEPENDS=3D
>=20
> BUILD_DEPENDS=3D
>=20
> RUN_DEPENDS=3D
>=20
> USE_FOO
> FOO_ARGS
> USE_BAR
>=20
> USERS
> GROUPS

*dEPENDS and USE* are really the same thing, dependencies (with, maybe,
some rare exceptions). So I'd say they should go together.

--=20
Ion-Mihai Tetcu <itetcu@FreeBSD.org>