Date: Fri, 19 May 2017 21:43:46 -0600 From: Adam Weinberger <adamw@adamw.org> To: Dan Langille <dvl@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r441282 - in head: . security security/acme.sh Message-ID: <989C2BB0-AC4E-4C76-AB15-9F616A6EF392@adamw.org> In-Reply-To: <201705200227.v4K2RjjG055940@repo.freebsd.org> References: <201705200227.v4K2RjjG055940@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 19 May, 2017, at 20:27, Dan Langille <dvl@FreeBSD.org> wrote: >=20 > Author: dvl > Date: Sat May 20 02:27:45 2017 > New Revision: 441282 > URL: https://svnweb.freebsd.org/changeset/ports/441282 >=20 > Log: > A pure Unix shell script implementing ACME client protocol >=20 > Differential Revision: https://reviews.freebsd.org/D10308 >=20 > Added: > head/security/acme.sh/ > head/security/acme.sh/Makefile (contents, props changed) > head/security/acme.sh/distinfo (contents, props changed) > head/security/acme.sh/pkg-descr (contents, props changed) > Modified: > head/GIDs > head/UIDs > head/security/Makefile >=20 >=20 > +RUN_DEPENDS=3D curl:ftp/curl > + > +OPTIONS_DEFINE=3D CURL DOCS WGET > +OPTIONS_DEFAULT=3D CURL > +CURL_DESC=3D Add ftp/curl as a run-time dependency > +WGET_DESC=3D Add ftp/wget as a run-time dependency > + > +CURL_RUN_DEPENDS=3D curl:ftp/curl > +WGET_RUN_DEPENDS=3D wget:ftp/wget Hi Dan, You have curl as a mandatory and optional dependency, which effectively = makes curl mandatory. I think you want to use OPTIONS_SINGLE or = OPTIONS_MULTI here, to make it an actual choice between the two of them. Also the descriptions are a bit strange. I mean, it does add them as a = dependency, but I think an end-user would be more concerned with what = curl or wget does for acme.sh, no? # Adam --=20 Adam Weinberger adamw@adamw.org https://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?989C2BB0-AC4E-4C76-AB15-9F616A6EF392>