From owner-freebsd-ports Sun Dec 5 12:12:33 1999 Delivered-To: freebsd-ports@freebsd.org Received: from shale.csir.co.za (shale.csir.co.za [146.64.46.5]) by hub.freebsd.org (Postfix) with ESMTP id 8E8EB15447; Sun, 5 Dec 1999 12:12:25 -0800 (PST) (envelope-from reg@shale.csir.co.za) Received: from granite.hip.berkeley.edu (granite.hip.berkeley.edu [136.152.155.25]) by shale.csir.co.za (8.9.3/8.9.3) with ESMTP id WAA66767; Sun, 5 Dec 1999 22:13:21 +0200 (SAT) (envelope-from reg@shale.csir.co.za) Received: (from reg@localhost) by granite.hip.berkeley.edu (8.9.3/8.9.3) id MAA61881; Sun, 5 Dec 1999 12:11:36 -0800 (PST) (envelope-from reg) Date: Sun, 5 Dec 1999 12:11:36 -0800 From: Jeremy Lea To: Jeroen Ruigrok/Asmodai Cc: vanilla@FreeBSD.ORG, ports@FreeBSD.ORG Subject: Re: glib12/gtk12 ports Message-ID: <19991205121136.A82697@shale.csir.co.za> References: <19991205154751.B41237@daemon.ninth-circle.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0pre3i In-Reply-To: <19991205154751.B41237@daemon.ninth-circle.org> Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Hi, I'm the origionator of most of the patches in these two ports. On Sun, Dec 05, 1999 at 03:47:51PM +0100, Jeroen Ruigrok/Asmodai wrote: > I mean, some patches offsets are off by 5000 lines, try to fix things > which shouldn't be fixed (like poll checking, which is present in > current autoconf scripts) or insert things which are present in the > newer configure scripts. Please be very careful playing here. The poll checks are out of date for -current, which now has poll in libc_r, but not for -stable AFAIK. The configure scripts find the poll in libc though and causes the build to fail. Also, the policy on the patches (as with all the GNOME ports) has been to minimise the diffs to the patches, and only regenerate them when they fail to apply to a new version. It just makes reading of diffs of patches easier. > I shall be reworking the patches unless you give me a sign not to, but I > am not happy about this patches dir's bitrot. It reeks of bad practice. That's uncalled for, and rude, and I'd ask that you apologise to Vanilla. -Jeremy -- | What will people think when they hear that I'm a Jesus freak? --+-- What will people do when they find that it's true? | I don't really care if they label me a Jesus Freak, | There ain't no disguising the truth. - d c Talk To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message