From owner-cvs-src@FreeBSD.ORG  Tue Feb 28 14:28:05 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@freebsd.org
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E4F6616A420;
	Tue, 28 Feb 2006 14:28:05 +0000 (GMT)
	(envelope-from deischen@freebsd.org)
Received: from mail.ntplx.net (mail.ntplx.net [204.213.176.10])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7EB1843D45;
	Tue, 28 Feb 2006 14:28:05 +0000 (GMT)
	(envelope-from deischen@freebsd.org)
Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11])
	by mail.ntplx.net (8.13.5/8.13.5/NETPLEX) with ESMTP id k1SES4Qk027434; 
	Tue, 28 Feb 2006 09:28:04 -0500 (EST)
Date: Tue, 28 Feb 2006 09:28:04 -0500 (EST)
From: Daniel Eischen <deischen@freebsd.org>
X-X-Sender: eischen@sea.ntplx.net
To: Xin LI <delphij@freebsd.org>
In-Reply-To: <20060228075203.GA74787@hub.freebsd.org>
Message-ID: <Pine.GSO.4.43.0602280926150.23070-100000@sea.ntplx.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.ntplx.net)
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/lib/libc/rpc auth_des.c auth_none.c auth_unix.c
 clnt_dg.c clnt_raw.c clnt_simple.c clnt_vc.c getpublickey.c
 key_call.c
 mt_misc.c mt_misc.h rpc_com.h rpc_generic.c rpc_soc.c rpcb_cl
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Daniel Eischen <deischen@freebsd.org>
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Feb 2006 14:28:06 -0000

On Tue, 28 Feb 2006, Xin LI wrote:
>
> On Mon, Feb 27, 2006 at 10:10:59PM +0000, Daniel Eischen wrote:
> > deischen    2006-02-27 22:10:59 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     lib/libc/rpc         auth_des.c auth_none.c auth_unix.c
> >                          clnt_dg.c clnt_raw.c clnt_simple.c
> >                          clnt_vc.c getpublickey.c key_call.c
> >                          mt_misc.c rpc_com.h rpc_generic.c
> >                          rpc_soc.c rpcb_clnt.c svc.c svc_auth.c
> >                          svc_dg.c svc_generic.c svc_raw.c
> >                          svc_run.c svc_simple.c svc_vc.c
> >   Added files:
> >     lib/libc/rpc         mt_misc.h
>
> I think we used to have a compiler bug which has hidden the
> API inconsistency where yp related functions having weak
> constant constraints, while the other part in libc do.
>
> Seems that getpublickey.c change has triggered the compiler
> to (correctly) generate warnings about the const/variable
> inconsistency, and thus broken the world...  Perhaps we
> should add const constraint for certain yp related stuff?

I built world with these changes, so I'm not sure where
there is a problem.  If you can reproduce a build failure
and know what the fix is, please commit it.

-- 
DE