From nobody Wed Apr 22 22:09:32 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g1D0c5Qm3z6ZwnD; Wed, 22 Apr 2026 22:09:36 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g1D0c3Frfz3QM5; Wed, 22 Apr 2026 22:09:36 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776895776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nsoesV8vTZVO/4R5flrnpXGoZkrKQCXST6JbhHkRSOw=; b=E+K9d07Es0WHffN8VUXn3R9NSLGK7Zx2V1en5LgJqdpRTn/WhdLA7RD3PtNrPgVOMzjELY LZr/PGkpXJWlkpDtEg3VC07/WlXK1j2Xb8Z6ZjDhHH2aBiEumidQJMurB9yFaiUz65eG0/ K/E0F1OXlEW7I1KTu1f2U7naq1R/2PheplTTnmgLy5lW0hRZdQ2Adi9dMUuk3vPZRBvJHc zby+J2WAsRmjlT+WhYqwFHQteDzT6Trics9qRyuVXI6Ow5S0fUo39r7fl+pxbkBXVzEtqZ w3V8XLpI2rf/ce7AH7vTsKL/dIUwM0qZgbjvX1yKaoSlMw+lTO7NP5lRJoy1qA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776895776; a=rsa-sha256; cv=none; b=v8azaEJFbOkKhOyQs09BDJp/dzhuFjOMBrnMepAh2Ol8w2+TPZzRNZqrj631muJ9+Z/XG6 oHSQjKHd7rnRfxA/ogFW/p9X37teLaEXihiinpX5FBeRGwHvoToGzJltdcftwkZC9DbyjC d6CllN/ZXSGJG1XMqbr03dIThZ43AnysSCYoksJjhwLYxKCka+QdUgik7NIVKVmwR56QwM c4/woMRQgQUXDVfiEWIdk7nd+aOoFm/BTo1XJpWII3Q3jzcx/wjYqQChsR8QJZ+H7xl3zU XX8W8+NXikFeuckpHtIi60uYmITnIoOV6z839CyN7BC9BADwSEdpzietfdw2Fw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776895776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nsoesV8vTZVO/4R5flrnpXGoZkrKQCXST6JbhHkRSOw=; b=Q8D3kPXpN/vPQUA8phz/mNZasYUvjX1UfjdTgAQ95PplJLtQNDiqJe+oleOPWzByYdFJ8S VJpyoq9q3gHy4uUNHrQEGXU3RZGtAAo1sT7O4RUEevpMSzuHcp2EK7AlsYvI9fBuD4s5du vY4dPsK1bWu/6rUoWRxFOuj4YGsIa3XuUzxr/55eD6IqOC7xC4V+H+bZ3Ql4Icv2EKpiYI 35nRQFJO/LdNNj56HMvqgNQDYy88aSPRDvoEoweiJXfOQdDoUSyV18Tc302lisKqPMlpqq +58iypJt+15v4irmpkbFhw/U1HD2aHgUB/6v8o0uqMGx6ZTn3yKC4/g2PibGvg== Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E7" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4g1D0c1gwyzHKK; Wed, 22 Apr 2026 22:09:36 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id 61853A64805; Wed, 22 Apr 2026 22:09:11 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id A358B2D029E9; Wed, 22 Apr 2026 22:09:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id yx5nXXjN6AqH; Wed, 22 Apr 2026 22:09:32 +0000 (UTC) Received: from nv.t4-02.sbone.de (nv.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 8BEF42D029D8; Wed, 22 Apr 2026 22:09:32 +0000 (UTC) Date: Wed, 22 Apr 2026 22:09:32 +0000 (UTC) From: "Bjoern A. Zeeb" To: Pouria Mousavizadeh Tehrani cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org, Weixie Cui Subject: Re: git: edb302bb49e0 - main - linuxkpi: Fix strlcpy size in linuxkpi_alloc_netdev() In-Reply-To: <69e934f2.26c9d.7222fed6@gitrepo.freebsd.org> Message-ID: <5o7qr01-sq55-n5o7-1419-89r528s53n2p@mnoonqbm.arg> References: <69e934f2.26c9d.7222fed6@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Wed, 22 Apr 2026, Pouria Mousavizadeh Tehrani wrote: > The branch main has been updated by pouria: > > URL: https://cgit.FreeBSD.org/src/commit/?id=edb302bb49e00723030b84624f16217f18760564 > > commit edb302bb49e00723030b84624f16217f18760564 > Author: Weixie Cui > AuthorDate: 2026-03-31 10:21:30 +0000 > Commit: Pouria Mousavizadeh Tehrani > CommitDate: 2026-04-22 20:51:48 +0000 > > linuxkpi: Fix strlcpy size in linuxkpi_alloc_netdev() > > `sizeof(*ndev->name)` is `sizeof(char)`, not IFNAMSIZ, so > the interface name was effectively limited to a single byte. > Use `sizeof(ndev->name)` for the `char name[IFNAMSIZ]` member. > > Signed-off-by: Weixie Cui > Reviewed by: pouria > Pull-Request: https://github.com/freebsd/freebsd-src/pull/2111 Fixes: d105895844848 Thanks! > --- > sys/compat/linuxkpi/common/src/linux_netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sys/compat/linuxkpi/common/src/linux_netdev.c b/sys/compat/linuxkpi/common/src/linux_netdev.c > index ce9153614104..11bbbfe6e279 100644 > --- a/sys/compat/linuxkpi/common/src/linux_netdev.c > +++ b/sys/compat/linuxkpi/common/src/linux_netdev.c > @@ -405,7 +405,7 @@ linuxkpi_alloc_netdev(size_t len, const char *name, uint32_t flags, > /* Always first as it zeros! */ > linuxkpi_init_dummy_netdev(ndev); > > - strlcpy(ndev->name, name, sizeof(*ndev->name)); > + strlcpy(ndev->name, name, sizeof(ndev->name)); > > /* This needs extending as we support more. */ > > > -- Bjoern A. Zeeb r15:7