From owner-freebsd-net@FreeBSD.ORG Thu Aug 20 12:49:39 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 90928106568B for ; Thu, 20 Aug 2009 12:49:39 +0000 (UTC) (envelope-from barney_cordoba@yahoo.com) Received: from n6b.bullet.mail.ac4.yahoo.com (n6b.bullet.mail.ac4.yahoo.com [76.13.13.76]) by mx1.freebsd.org (Postfix) with SMTP id 33E758FC51 for ; Thu, 20 Aug 2009 12:49:38 +0000 (UTC) Received: from [76.13.13.26] by n6.bullet.mail.ac4.yahoo.com with NNFMP; 20 Aug 2009 12:49:38 -0000 Received: from [76.13.10.161] by t3.bullet.mail.ac4.yahoo.com with NNFMP; 20 Aug 2009 12:49:38 -0000 Received: from [127.0.0.1] by omp102.mail.ac4.yahoo.com with NNFMP; 20 Aug 2009 12:49:38 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 521477.18747.bm@omp102.mail.ac4.yahoo.com Received: (qmail 25164 invoked by uid 60001); 20 Aug 2009 12:49:38 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1250772578; bh=heZ5f0nY5RBnap70Sq6WfBTs5luW8Ob4/GIhnWOAIWo=; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=godl/g8bU3b2FjWQOhVWX1Snnd37FXTA0HR7DqBsSCpp8E6OCzOg2ooZT0ouMALpM84X84mznc2OWBkm988fpSEObveXvFwSGkbdwNlOuhSVZluXLUfSi+BDFZHbvmOPNag6qVA3F6iwshyHWrwzbon98n7w/g1rpCWt579vYpI= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=4+GAxJOiXU5X1P1umKqod51/9nVHThCFzvrl/06JSB1EzSi0+qGwp1oAPCzslVf7tW4nEeNovKbYgMGt6ntmpFRYDKhjP15sRIPoZsxldCHK8z5l3bjbk0SeyFAAuT0UW6TQGKY5fnTumbAPQZfpXMTOZLnx0bKpOZbzJzbJ9pg=; Message-ID: <435336.24858.qm@web63908.mail.re1.yahoo.com> X-YMail-OSG: oYusjDUVM1lB0K8.bk21VpKGJeg835yK9alMcQFrbNuCrW9U46._dp8AYrCHoZwo2L7pTHcu0VNhJQq7T1iZBDpxUfGXmml73oJqsrZGuQIL3OJxVJPjunTwE5Wu_a4TZB6o2vYoD91L8N8c3h2ZrgR5hMZ2kU13.wldTVKwL_i2mtY.rhCIRjFOR6qs2Y8EsL4rGg3cbHXsTpvAXHYmwGfFwoZrZQFaNguKJAJf90Cd09Lia2J0CPQ9OX6HVSENRqUWCmQRuKJLiF8ozyqFUpXH Received: from [66.176.162.245] by web63908.mail.re1.yahoo.com via HTTP; Thu, 20 Aug 2009 05:49:38 PDT X-Mailer: YahooMailClassic/6.1.2 YahooMailWebService/0.7.338.1 Date: Thu, 20 Aug 2009 05:49:38 -0700 (PDT) From: Barney Cordoba To: Manish Vachharajani In-Reply-To: <5bc218350908191146j2a22f8dcrdecb0b67eedce5c2@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-net@freebsd.org Subject: Re: Dropped vs. missed packets in the ixgbe driver X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Aug 2009 12:49:39 -0000 =0A=0A--- On Wed, 8/19/09, Manish Vachharajani wrote:=0A=0A> From: Manish Vachharajani =0A>= Subject: Re: Dropped vs. missed packets in the ixgbe driver=0A> To: "Barne= y Cordoba" =0A> Cc: freebsd-net@freebsd.org=0A> D= ate: Wednesday, August 19, 2009, 2:46 PM=0A> Agreed, the errors are reporte= d but=0A> missed packets are not.=A0 The=0A> question is, is the correct fi= x to just add stats.mpc[0] to=0A> if_ierrors=0A> in that line or to add it = to if_iqdrops.=A0 The fix is=0A> easy once we=0A> agree on what the correct= behavior is.=0A> =0A> Manish=0A> =0A> > Barney wrote:=0A> >=0A> > if you l= ook in ixgbe_update_stats_counters at the=0A> bottom:=0A> >=0A> > =A0 =A0 = =A0 =A0ifp->if_ierrors =3D missed_rx +=0A> adapter->stats.crcerrs +=0A> > = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0adapter->stats.rlec;=0A> >=0A> > the errors = are added in.=0A> >=0A> > BC=0A=0AHuh? missed_rx are the missed packets. So= they are counted.=0A=0ABC=0A=0A=0A