From owner-cvs-all@FreeBSD.ORG Sat Sep 30 16:51:58 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2980016A403; Sat, 30 Sep 2006 16:51:58 +0000 (UTC) (envelope-from ume@mahoroba.org) Received: from ameno.mahoroba.org (gw4.mahoroba.org [218.45.22.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5FD8C43D46; Sat, 30 Sep 2006 16:51:56 +0000 (GMT) (envelope-from ume@mahoroba.org) Received: from kasuga.mahoroba.org (IDENT:wjya8NiJ9Mv2tWHj97PBC7J/bwMJZelzWi30r3SfiW4h7ZySs/1yivor9+SdrgFW@kasuga-iwi.mahoroba.org [IPv6:2001:2f0:104:8010:212:f0ff:fe52:6ac]) (user=ume mech=CRAM-MD5 bits=0) by ameno.mahoroba.org (8.13.8/8.13.8) with ESMTP/inet6 id k8UGpjCl009442 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 1 Oct 2006 01:51:47 +0900 (JST) (envelope-from ume@mahoroba.org) Date: Sun, 01 Oct 2006 01:51:45 +0900 Message-ID: From: Hajimu UMEMOTO To: John Hay In-Reply-To: <20060930162039.GA59699@zibbi.meraka.csir.co.za> References: <200609301408.k8UE8vpM069161@repoman.freebsd.org> <20060930162039.GA59699@zibbi.meraka.csir.co.za> User-Agent: xcite1.38> Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.0.50 (i386-pc-freebsd) MULE/5.0 (SAKAKI) X-Operating-System: FreeBSD 6.2-PRERELEASE X-PGP-Key: http://www.imasy.or.jp/~ume/publickey.asc X-PGP-Fingerprint: 1F00 0B9E 2164 70FC 6DC5 BF5F 04E9 F086 BF90 71FE Organization: Internet Mutual Aid Society, YOKOHAMA MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-3.0rc3 (ameno.mahoroba.org [IPv6:2001:2f0:104:8010::1]); Sun, 01 Oct 2006 01:51:48 +0900 (JST) X-Virus-Scanned: by amavisd-new X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.1.5 X-Spam-Checker-Version: SpamAssassin 3.1.5 (2006-08-29) on ameno.mahoroba.org Cc: John Hay , src-committers@FreeBSD.org, Hajimu UMEMOTO , cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet6 nd6.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Sep 2006 16:51:58 -0000 Hi, >>>>> On Sat, 30 Sep 2006 18:20:39 +0200 >>>>> John Hay said: jhay> On Sat, Sep 30, 2006 at 11:33:35PM +0900, Hajimu UMEMOTO wrote: > jhay> FreeBSD src repository > > jhay> Modified files: > jhay> sys/netinet6 nd6.c > jhay> Log: > jhay> My previous commit broke "route add -inet6 -interface gif0". > jhay> Fix that by excluding point-to-point interfaces. > > > - } else if (req == RTM_ADD && SDL(gate)->sdl_alen == 0) { > > + } else if (req == RTM_ADD && SDL(gate)->sdl_alen == 0 && > > + (ifp->if_flags & (IFF_POINTOPOINT | IFF_LOOPBACK)) == 0) { > > ln->ln_state = ND6_LLINFO_INCOMPLETE; > > Umm, it seems still there is a problem. We are using -interface not > only for point-to-point interface and loopback. > I'm not sure but can we check `(rt->rt_flags & RTF_HOST) != 0', here? jhay> That would work better yes. Is there a reason you feel unsure about it? jhay> Or is it just a case of not having tested it? Because, I was just unsure of your intention, and I'm not having tested it. Sincerely, -- Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan ume@mahoroba.org ume@{,jp.}FreeBSD.org http://www.imasy.org/~ume/