From owner-freebsd-bugs  Fri Jan  9 22:30:03 1998
Return-Path: <owner-freebsd-bugs>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id WAA25304
          for bugs-outgoing; Fri, 9 Jan 1998 22:30:03 -0800 (PST)
          (envelope-from owner-freebsd-bugs)
Received: (from gnats@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id WAA25297;
          Fri, 9 Jan 1998 22:30:01 -0800 (PST)
          (envelope-from gnats)
Resent-Date: Fri, 9 Jan 1998 22:30:01 -0800 (PST)
Resent-Message-Id: <199801100630.WAA25297@hub.freebsd.org>
Resent-From: gnats (GNATS Management)
Resent-To: freebsd-bugs
Resent-Reply-To: FreeBSD-gnats@FreeBSD.ORG, sanpei@yy.cs.keio.ac.jp
Received: from titanium.yy.cs.keio.ac.jp (titanium.yy.cs.keio.ac.jp [131.113.47.73])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id WAA25035
          for <FreeBSD-gnats-submit@freebsd.org>; Fri, 9 Jan 1998 22:24:04 -0800 (PST)
          (envelope-from sanpei@yy.cs.keio.ac.jp)
Received: from lavender.sanpei.org (u1204.seaple.icc.ne.jp [203.140.41.204])
	by titanium.yy.cs.keio.ac.jp (8.8.8+3.0Wbeta11/3.6W) with ESMTP id PAA18098
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 10 Jan 1998 15:23:22 +0900 (JST)
Received: (from sanpei@localhost)
	by lavender.sanpei.org (8.8.5/3.6Wbeta4) id PAA11990;
	Sat, 10 Jan 1998 15:23:21 +0900 (JST)
Message-Id: <199801100623.PAA11990@lavender.sanpei.org>
Date: Sat, 10 Jan 1998 15:23:21 +0900 (JST)
From: sanpei@yy.cs.keio.ac.jp
Reply-To: sanpei@yy.cs.keio.ac.jp
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: bin/5473: tzsetup does not create /etc/wall_cmoc_clock file.
Sender: owner-freebsd-bugs@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk


>Number:         5473
>Category:       bin
>Synopsis:       tzsetup does not create /etc/wall_cmoc_clock file.
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan  9 22:30:00 PST 1998
>Last-Modified:
>Originator:     MIHIRA Yoshiro
>Organization:
Keio Univ.
>Release:        FreeBSD 2.2.2-RELEASE i386
>Environment:

	FreeBSD-current and FreeBSD-2.2(stable)

>Description:

	tzsetup does not create /etc/wall_cmos_clock file.
	`if else' pair is not correct between indent and C grammer
	as below.

>How-To-Repeat:

	as root, /usr/sbin/tzsetup or install system via boot.flp

>Fix:

--- tzsetup.c.orig	Sat Jan 10 14:53:08 1998
+++ tzsetup.c	Sat Jan 10 15:01:16 1998
@@ -655,12 +655,15 @@
 	init_dialog();
 	if (!dialog_yesno("Select local or UTC (Greenwich Mean Time) clock",
 			  "Is this machine's CMOS clock set to UTC?  If it is set to local time,\n"
-			  "please choose NO here!", 7, 72))
-		if (reallydoit)
+			  "please choose NO here!", 7, 72)) {
+		if (reallydoit) {
 			system("rm -f /etc/wall_cmos_clock");
-	else
-		if (reallydoit)
+		}
+	} else {
+		if (reallydoit) {
 			system("touch /etc/wall_cmos_clock");
+		}
+	}
 	dialog_clear_norefresh();
 	dialog_menu("Time Zone Selector", "Select a region", -1, -1, 
 		    NCONTINENTS, -NCONTINENTS, continents, 0, NULL, NULL);
>Audit-Trail:
>Unformatted: