From owner-freebsd-wireless@FreeBSD.ORG Sun Jul 28 19:25:09 2013 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 98F52AF6 for ; Sun, 28 Jul 2013 19:25:09 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-wg0-x233.google.com (mail-wg0-x233.google.com [IPv6:2a00:1450:400c:c00::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 31B4E26D9 for ; Sun, 28 Jul 2013 19:25:09 +0000 (UTC) Received: by mail-wg0-f51.google.com with SMTP id a12so488388wgh.30 for ; Sun, 28 Jul 2013 12:25:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=c36v8Rfi5Os88fQzb6yYthBl3D4TVmyzyBPvxSkPFVA=; b=LEmYs5EteIoy1iwlL9gzvAWyHkwUBJ+8enNDo6BZOGraPLZJHzpaGJHmywJMfKoY7z PZH6fWKcrojB7KE8cl4pBHc+yxVC0cxaljkY1djbW+j+VVrLeeuL+NdZ2buE91gFxMhA Bq2W3Y7CiS4O7svlTagPeYMvmSA0ZMnZiqPm7f8U9NEnyetaQUzHqua2+429NiD+4UNL 37HZtb+MRI1PjeEszGZcCUKlHnWh0qGpF5Glg8ACZCQF6hArMXSHT2jnre/xQcVTrqoX 2mAmRqWLcSLwyoXs9eqy7nnhCMPUo+FHdGO4KHd1GHRtUkX2Rsb4N5a0Ds1POj4bIVtX 2lAQ== MIME-Version: 1.0 X-Received: by 10.180.39.212 with SMTP id r20mr4943775wik.30.1375039507452; Sun, 28 Jul 2013 12:25:07 -0700 (PDT) Received: by 10.217.94.132 with HTTP; Sun, 28 Jul 2013 12:25:07 -0700 (PDT) In-Reply-To: <51f3f0ce.055a420a.2e1e.fffff220SMTPIN_ADDED_BROKEN@mx.google.com> References: <51f3f0ce.055a420a.2e1e.fffff220SMTPIN_ADDED_BROKEN@mx.google.com> Date: Sun, 28 Jul 2013 12:25:07 -0700 Message-ID: Subject: Re: [IWN] Reviw split 2 From: Adrian Chadd To: Cedric GROSS Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-wireless@freebsd.org X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jul 2013 19:25:09 -0000 Hi! Feedback time! - DPRINTF(sc, IWN_DEBUG_TRACE, "->%s done\n", __func__); + DPRINTF(sc, IWN_DEBUG_TRACE, "->%s: end\n",__func__); + .. all that did was delete a space and add a new line. Just add the space back in there, delete the new line; then that part of the diff will disappear. - if (!(sc->sc_flags & IWN_FLAG_HAS_11N)) { + if (!(sc->sc_flags & IWN_FLAG_HAS_11N)){ Again, you've just deleted a space. You don't need to do that. :-) Just put the space back in, that part of the diff will disappear. - break; +#endif + break; .. the #endif is fine, but you reformatted the "break" line. tsk. There's another break, and another DPRINTF that you did that to. Then in the include file: -#define IWN_INT 0x008 +#define IWN_INT 0x008 #define IWN_INT_MASK 0x00c -#define IWN_FH_INT 0x010 -#define IWN_RESET 0x020 +#define IWN_FH_INT 0x010 +#define IWN_GPIO_IN 0x018 /* read external chip pins */ +#define IWN_RESET 0x020 #define IWN_GP_CNTRL 0x024 -#define IWN_HW_REV 0x028 -#define IWN_EEPROM 0x02c +#define IWN_HW_REV 0x028 +#define IWN_EEPROM 0x02c .. most of those are just tab spaces. You can eliminate those, and all you'd be adding in is the GPIO_IN line. Here's my .vimrc file. It includes colour marking for tabs/spaces, indenting, and lines longer than 78 characters. Thank Bernhard for it. It's great for inspecting code and diffs for things like whitespace changes, trailing whitespace at the end of a line, tabs which should be spaces (and vice versa), etc. adrian@lucy:~]> cat ~/.vimrc " LCD-friendly! :set bg=dark " Do general syntax highlighting :syntax enable " Highlight tab characters as >. (with . being tab spaces) " Highlight extra spaces (ie, before the end of line) with "C" :set list :set listchars=tab:>.,trail:C :highlight NearLength ctermbg=magenta ctermfg=white guibg=#592959 :highlight OverLength ctermbg=red ctermfg=white guibg=#592929 " Match characters after position 78; set highlight to be magenta " Second match characters after position 80; set highlight to be red :match NearLength /\%78v.\+/ :2match OverLength /\%81v.\+/ " Enable auto-indenting :set ai On 27 July 2013 09:09, Cedric GROSS wrote: > Hello, > > > > A new patch. > > > > This one add : > > - a debugging function printing uCode registery. > > - IWN_DEBUG make option > > > > A review has be done also which can safely undefined IWN_DEBUG. Previously > do so lead to compile error. > > > > Cedric > > > > > _______________________________________________ > freebsd-wireless@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-wireless > To unsubscribe, send any mail to "freebsd-wireless-unsubscribe@freebsd.org"