From nobody Fri Oct 17 16:43:20 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cp9cj6Q7pz6CKCN for ; Fri, 17 Oct 2025 16:43:33 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: from mail-yx1-f54.google.com (mail-yx1-f54.google.com [74.125.224.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cp9cj4LFdz3K8Z for ; Fri, 17 Oct 2025 16:43:33 +0000 (UTC) (envelope-from rlibby@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-yx1-f54.google.com with SMTP id 956f58d0204a3-63e17c0fefbso1359704d50.1 for ; Fri, 17 Oct 2025 09:43:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760719413; x=1761324213; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tai5WQpbGipZh4x2Qbd6VlKIvDXep+nILMDRnzE0HZk=; b=LAdXihxyhS4V1QRKv7rF6LEGEmvoCUC1f9oT/4KBtoFkh4vR0l9PnZZmbwnFDQpIhS f2znafqMani2Pg92UtN7oPuz28hV9+8elWbp14dNwQuxsN0ZjJMwaYoMcSCSNbQizsVq c9JHZ5CwT5GiERpmPgmsOKkUf6O4D7e4XUrl45SrGH1LLqM6CS8gD29cA9Dwk7cBiioB xZ5DWt4aM7JgiZsEf5gkKVBkG/kHYFfL+oSE16wj4d4C12QgxpoTtt0CSZlu59UyVpir GR7DCOti/D5WjLLEwD26fpcciaM5Lt9fhlrNaRx/bCMqZWjjDpejfnauJ2s3RAkzAZkF C/Pg== X-Forwarded-Encrypted: i=1; AJvYcCWlJwVz4WyQjMqg5WK/M+hNPyGJW64OCIOtsRBeL6HTN5E1ifMM/11+WPdXhElS7nitufjCnFjSrpwVjltpAhAOjl3K@freebsd.org X-Gm-Message-State: AOJu0Yy8WVN5iQAlau3G2Ic6SpSk7hT7icLKj5W4q8f2i9PntqWGePY4 9KgEddKbH1H3M+F5SuxJN39tyV3jwoOHfpuLh+9uoo6lWUWai8wK3sFDyshCS6kt X-Gm-Gg: ASbGncvxwylM8E+0SrnsnosuE+Za82le58jB0XXJFEuyUQ9dTXRtwTBDbOWOFJx8PrH VK/2kX5eGtWqYeuPL4y77Ldnxy2UsRe0yt9iR7D21IOeqVCm0JdYav5XxKlWjXEHqd692LYw+9W LqRzxjvptXUt7CgCuDpYS1r5g6RNoletmes0uOIwZ0yBb5wN3F0mtF34Qb2NIB93x/of59xs2Lb z+r7OqXsB8qkO1GfIivaNh0UbmaGfupVVsxjGNck9d0h4Kpi+8tW4GwayIj5aYEaWLMFsZFG69S DPmX/9BeELHCYR14WXFoERDmaEKehK37W/pAQo97fuMP5YGfxKb4h9FV/a+Vz1P+m45U68zxKVw OQNXmbfmRxYM8CSIqfUWjoAvvJ8dwivWKXxAoNncRmXWhkHgPEPfwCKLwZG0zww3GDGEdbOsJN1 wu2wearOtm0WSJeKHIOMpsPzh6uDtFpkzViTbtpr2H56lH5dFBYase9F9R X-Google-Smtp-Source: AGHT+IG4ttfNB2BeAysmkvTBNLLSETn9nuIjBdPT4mnfa7mjK24RygzjgyzJQA9eCBHexWMRSPt4Fg== X-Received: by 2002:a05:690e:1b55:b0:63c:f5a6:f2fd with SMTP id 956f58d0204a3-63e161f759fmr2938768d50.63.1760719412620; Fri, 17 Oct 2025 09:43:32 -0700 (PDT) Received: from mail-yx1-f46.google.com (mail-yx1-f46.google.com. [74.125.224.46]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-63e267fe371sm24996d50.19.2025.10.17.09.43.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Oct 2025 09:43:32 -0700 (PDT) Received: by mail-yx1-f46.google.com with SMTP id 956f58d0204a3-635c9db8a16so2097556d50.0 for ; Fri, 17 Oct 2025 09:43:32 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCX08kHDjJdZwLeDbvjwRdEltqyF64KjHWkR4B3PsJnP9MRMPZj8OEv0KngpXBXCckKXpimIPm88MrivsI9HrEULz6bj@freebsd.org X-Received: by 2002:a05:690e:11c4:b0:63e:1ca0:be73 with SMTP id 956f58d0204a3-63e1ca0c207mr2164662d50.37.1760719411795; Fri, 17 Oct 2025 09:43:31 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202510162205.59GM5ZvD042942@gitrepo.freebsd.org> In-Reply-To: From: Ryan Libby Date: Fri, 17 Oct 2025 09:43:20 -0700 X-Gmail-Original-Message-ID: X-Gm-Features: AS18NWDOI7vD-owN-IYKQevM9EL5lc7dOzZKONklI3QsgrIGz-UqVcxkcEHY8gI Message-ID: Subject: Re: git: 0050289464fa - main - style(9): white space after ; and around binary operators To: Mark Johnston Cc: Rick Macklem , "David E. O'Brien" , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_RCPT(0.00)[]; ASN(0.00)[asn:15169, ipnet:74.125.0.0/16, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cp9cj4LFdz3K8Z On Thu, Oct 16, 2025 at 4:58=E2=80=AFPM Mark Johnston w= rote: > > On Thu, Oct 16, 2025 at 04:21:45PM -0700, Rick Macklem wrote: > > Please be aware of the following snippets from "man 9 style": > > > > In general code can be considered "new code" when it makes up about 50% > > or more of the file(s) involved. This is enough to break precedents in > > the existing code and use the current style guidelines. > > > > Stylistic changes (including whitespace changes) are hard on the source > > repository and are to be avoided without good reason. > > +1 > > This kind of change accomplishes nothing except to be a source of merge > conflicts for others to deal with. > Not to pile on, but I would also suggest to avoid touching unrelated code in a single commit if not necessary. It helps avoid entanglement in backports. > > rick > > > > On Thu, Oct 16, 2025 at 3:05=E2=80=AFPM David E. O'Brien wrote: > > > > > > CAUTION: This email originated from outside of the University of Guel= ph. Do not click links or open attachments unless you recognize the sender = and know the content is safe. If in doubt, forward suspicious emails to ITh= elp@uoguelph.ca. > > > > > > The branch main has been updated by obrien: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D0050289464fa56ec79e060= b8d8378b9ff7145a0e > > > > > > commit 0050289464fa56ec79e060b8d8378b9ff7145a0e > > > Author: David E. O'Brien > > > AuthorDate: 2025-10-15 05:22:00 +0000 > > > Commit: David E. O'Brien > > > CommitDate: 2025-10-16 22:02:50 +0000 > > > > > > style(9): white space after ; and around binary operators > > > > > > in for() loops. Also, use 'while', where only the > > > conditional test of 'for' was used. > > > > > > Reviewed by: sjg