From owner-freebsd-bugs@FreeBSD.ORG Fri Jul 25 09:48:39 2014 Return-Path: Delivered-To: freebsd-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6D1258D0 for ; Fri, 25 Jul 2014 09:48:39 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 547272B08 for ; Fri, 25 Jul 2014 09:48:39 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.8/8.14.8) with ESMTP id s6P9mdUB049108 for ; Fri, 25 Jul 2014 09:48:39 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 192108] New: [patch] sed(1) bug in "addr1,+N" ranges Date: Fri, 25 Jul 2014 09:48:39 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 9.2-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: cejkar@fit.vutbr.cz X-Bugzilla-Status: Needs Triage X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2014 09:48:39 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192108 Bug ID: 192108 Summary: [patch] sed(1) bug in "addr1,+N" ranges Product: Base System Version: 9.2-STABLE Hardware: Any OS: Any Status: Needs Triage Severity: Affects Some People Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: cejkar@fit.vutbr.cz Created attachment 144962 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=144962&action=edit Proposed patch for review There is a bug in "addr1,+N" ranges in the case of last input line, let's try: # seq 1 4 | sed -ne '1,+0p' 1 # seq 1 4 | sed -ne '1,+1p' 1 2 # seq 1 4 | sed -ne '1,+2p' 1 2 3 4 <--- This line should not be printed!!! # seq 1 4 | sed -ne '1,+3p' 1 2 3 4 The reason is that in case of AT_RELLINE, lastline()'s TRUE in MATCH() is taken before the test for relative range next (process.c:291-297): ... if (MATCH(cp->a2)) { cp->startline = 0; lastaddr = 1; r = 1; } else if (linenum - cp->startline <= cp->a2->u.l) r = 1; else if ((cp->a2->type == AT_LINE && ... -- You are receiving this mail because: You are the assignee for the bug.