From owner-freebsd-current Tue Jan 27 18:54:55 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id SAA20718 for current-outgoing; Tue, 27 Jan 1998 18:54:55 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from zippy.dyn.ml.org (garbanzo@spain-36.ppp.hooked.net [206.169.228.36]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id SAA20712 for ; Tue, 27 Jan 1998 18:54:53 -0800 (PST) (envelope-from garbanzo@hooked.net) Received: from localhost (garbanzo@localhost) by zippy.dyn.ml.org (8.8.8/8.8.7) with SMTP id SAA03100; Tue, 27 Jan 1998 18:56:25 -0800 (PST) X-Authentication-Warning: zippy.dyn.ml.org: garbanzo owned process doing -bs Date: Tue, 27 Jan 1998 18:56:25 -0800 (PST) From: Alex X-Sender: garbanzo@zippy.dyn.ml.org To: Julian Elischer cc: current Subject: Re: PATCH: if_de.c #ifdef based version encoding In-Reply-To: <34CE4438.15FB7483@whistle.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk On Tue, 27 Jan 1998, Julian Elischer wrote: > David Greenman wrote: > > > > >The value of the manifest constant __FreeBSD__ is derived from the > > >compiler tools and not from the kernel being built. > > > > > >In other words, the value of __FreeBSD__ comes from the version of the > > >OS the tools were built on, not from the OS that's running or the one > > >that is being targeted. > > > > > >This means that if I build a v3 kernel using a v2 system's tools, the > > >"#if __FreeBSD__ >= 3" and "#if defined(__FreeBSD__) && __FreeBSD__ >= 3" > > >will not test true, even though that is, in fact, what I am building. > > > > > > > > >Version information should not be encoded in #ifdef's; that is what > > >branch tags are for. If I can check this code out, implicitly, I am > > >building a 3+ system. The "#if" tests are bogus. > > > > > >This patch allows people to compile v3 kernels containing if_de.c on v2 > > >systems. What about osreldate.h?? Doesn't that include a versionish number of sorts for the kernel/tools being built? Linux: The Microsoft Windows(tm) of the Unix(tm) world. - alex