From owner-cvs-all  Mon Dec 31  9:49:38 2001
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id E8C5437B433; Mon, 31 Dec 2001 09:49:33 -0800 (PST)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id EAA09221;
	Tue, 1 Jan 2002 04:49:26 +1100
Date: Tue, 1 Jan 2002 04:49:17 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender:  <bde@gamplex.bde.org>
To: Jake Burkholder <jake@locore.ca>
Cc: Poul-Henning Kamp <phk@FreeBSD.org>,
	<cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/sys/i386/i386 trap.c
In-Reply-To: <20011230211002.C9752@locore.ca>
Message-ID: <20020101042804.T7381-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Sun, 30 Dec 2001, Jake Burkholder wrote:

> Apparently, On Sun, Dec 30, 2001 at 11:43:59AM -0800,
> 	Poul-Henning Kamp said words to the effect of;
>
> > phk         2001/12/30 11:43:59 PST
> >
> >   Modified files:
> >     sys/i386/i386        trap.c
> >   Log:
> >   GC an alternate trap_pfault() which has rotted away behind an "#ifdef notyet"
> >   since 21-Mar-95 .
> >
> >   Revision  Changes    Path
> >   1.210     +0 -118    src/sys/i386/i386/trap.c
>
> This is the one that should have been used.  The existing one is broken because
> it allows faults on user memory in kernel mode without using copy{in,out} or
> {f,s}uword.  Apparently there is still broken kernel code that expects this to
> work.

I agree.  Some of the bitrot was fixed in my local version, but I never
got around to testing it.

What do the other arches do?  They all seem to be based on the ancient
version that did trap_pfault() inline in trap().  The i386 version stopped
doing this in rev.1.25 (1994/06/06).

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message