From owner-freebsd-multimedia@FreeBSD.ORG Fri Feb 9 19:36:27 2007 Return-Path: X-Original-To: multimedia@freebsd.org Delivered-To: freebsd-multimedia@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5919A16A408 for ; Fri, 9 Feb 2007 19:36:27 +0000 (UTC) (envelope-from mezz7@cox.net) Received: from eastrmmtao01.cox.net (eastrmmtao01.cox.net [68.230.240.38]) by mx1.freebsd.org (Postfix) with ESMTP id DF68E13C491 for ; Fri, 9 Feb 2007 19:36:26 +0000 (UTC) (envelope-from mezz7@cox.net) Received: from eastrmimpo01.cox.net ([68.1.16.119]) by eastrmmtao01.cox.net (InterMail vM.6.01.06.03 201-2131-130-104-20060516) with ESMTP id <20070209193626.JFFX2807.eastrmmtao01.cox.net@eastrmimpo01.cox.net>; Fri, 9 Feb 2007 14:36:26 -0500 Received: from mezz.mezzweb.com ([24.255.149.218]) by eastrmimpo01.cox.net with bizsmtp id MXcR1W00B4iy4EG0000000; Fri, 09 Feb 2007 14:36:25 -0500 Date: Fri, 09 Feb 2007 13:38:17 -0600 To: "Luigi Rizzo" From: "Jeremy Messenger" Content-Type: text/plain; format=flowed; delsp=yes; charset=us-ascii MIME-Version: 1.0 References: <20070209073353.A99372@xorpc.icir.org> <20070209105414.A1702@xorpc.icir.org> Content-Transfer-Encoding: Quoted-Printable Message-ID: In-Reply-To: <20070209105414.A1702@xorpc.icir.org> User-Agent: Opera Mail/9.10 (Linux) Cc: mi@aldan.algebra.com, multimedia@freebsd.org Subject: Re: vic patches for video4linux support X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2007 19:36:27 -0000 On Fri, 09 Feb 2007 12:54:14 -0600, Luigi Rizzo wrote: > On Fri, Feb 09, 2007 at 12:44:06PM -0600, Jeremy Messenger wrote: >> On Fri, 09 Feb 2007 09:33:53 -0600, Luigi Rizzo wrot= e: > ... >> > + fix configure to look for videodev.h in the place where it is on >> > FreeBSD, and disable v4l2 support for the time being as there >> > is none as far as i know; >> >> Disapprove because of hardcore. You should be replace from = >> patch-configure >> to REINPLACE_CMD with ${LOCALBASE}. Something like this (untest): > > Thanks for looking at it. > > will look at how to improve the patch, however what you suggest is > not enough in this case: Yes, it is in my second suggest. > there are [at least] two instances of the match > pattern, one of which i want to replace, the other i do not. You have strip out my other suggest about %%LOCALBASE%%, which it's what= = you want. Example: patch-configure: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D %%LOCALBASE%%/include/linux =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D Makefile: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D [...] @${REINPLACE_CMD} -e 's|%%LOCALBASE%%|${LOCALBASE}|g' \ =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > (also consider that the source is basically dead - nobody > is going to change it so there is little point in being > flexible on the input). > > ... >> > + add -I/usr/local/include in the search path, for the above file; >> >> Why? The CONFIGURE_ENV doesn't work? > > will try it, thanks If the one that we already have CONFIGURE_ENV doesn't work, then I am ok= = with patch. Have you test it without patch? Cheers, Mezz > cheers > luigi -- = mezz7@cox.net - mezz@FreeBSD.org FreeBSD GNOME Team - FreeBSD Multimedia Hat (ports, not src) http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org http://wiki.freebsd.org/multimedia - multimedia@FreeBSD.org