From owner-svn-ports-head@freebsd.org  Thu Aug  6 12:53:18 2020
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1E1B33A23F1;
 Thu,  6 Aug 2020 12:53:18 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4BMpM1724cz45xY;
 Thu,  6 Aug 2020 12:53:17 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id E201876E5; Thu,  6 Aug 2020 12:53:17 +0000 (UTC)
Date: Thu, 6 Aug 2020 12:53:17 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Danilo Eg??a Gondolfo <danilo@freebsd.org>
Cc: ports-committers <ports-committers@freebsd.org>,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r544245 - head/x11/sakura
Message-ID: <20200806125317.GA39512@FreeBSD.org>
References: <202008052155.075LtmtD072730@repo.freebsd.org>
 <20200806033440.GA53929@FreeBSD.org>
 <CAFU7VyOkoJ2yp6Oz88Tfkhts0GzVPDfKXJnyTbfJmmRS0QhcJw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFU7VyOkoJ2yp6Oz88Tfkhts0GzVPDfKXJnyTbfJmmRS0QhcJw@mail.gmail.com>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Aug 2020 12:53:18 -0000

On Thu, Aug 06, 2020 at 11:46:26AM +0100, Danilo Eg??a Gondolfo wrote:
> On Thu, Aug 6, 2020 at 4:34 AM Alexey Dokuchaev <danfe@freebsd.org> wrote:
> 
> > On Wed, Aug 05, 2020 at 09:55:48PM +0000, Danilo Egea Gondolfo wrote:
> > > New Revision: 544245
> > > URL: https://svnweb.freebsd.org/changeset/ports/544245
> > >
> > > @@ -14,9 +14,10 @@ LICENSE=   GPLv2
> > >  LIB_DEPENDS= libgnutls.so:security/gnutls \
> > >               libpcre2-8.so:devel/pcre2
> > >
> > > +USES=                cmake gnome pkgconfig gettext perl5 tar:bz2 xorg
> > > +
> > >  OPTIONS_DEFINE=      DOCS
> > >
> > > -USES=                cmake gnome pkgconfig gettext perl5 xorg
> > >  USE_GNOME=   cairo gdkpixbuf2 vte3
> > >  USE_XORG=    x11
> > >  USE_PERL5=   build
> >
> > I'd argue that USES was placed better before this change (right next to
> > USE_FOO knobs).  It should've been left where it was and OPTIONS_DEFINE
> > moved downwards instead.
> 
> Just tried to make portlint happy on this one ("USES should appear
> earlier").

I know why you did this, but it does not make the change less wrong.

./danfe