From owner-svn-src-user@freebsd.org  Wed May  4 03:34:36 2016
Return-Path: <owner-svn-src-user@freebsd.org>
Delivered-To: svn-src-user@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id CCDA2B2CC1E
 for <svn-src-user@mailman.ysv.freebsd.org>;
 Wed,  4 May 2016 03:34:36 +0000 (UTC)
 (envelope-from bdrewery@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id BDA19147D;
 Wed,  4 May 2016 03:34:36 +0000 (UTC)
 (envelope-from bdrewery@FreeBSD.org)
Received: from mail.xzibition.com (localhost [IPv6:::1])
 by freefall.freebsd.org (Postfix) with ESMTP id B4A6C15EA;
 Wed,  4 May 2016 03:34:36 +0000 (UTC)
 (envelope-from bdrewery@FreeBSD.org)
Received: from mail.xzibition.com (localhost [172.31.3.2])
 by mail.xzibition.com (Postfix) with ESMTP id 5BC48D528;
 Wed,  4 May 2016 03:34:36 +0000 (UTC)
X-Virus-Scanned: amavisd-new at mail.xzibition.com
Received: from mail.xzibition.com ([172.31.3.2])
 by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new,
 port 10026)
 with LMTP id ulxdLRlAxguo; Wed,  4 May 2016 03:34:33 +0000 (UTC)
Subject: Re: svn commit: r299037 - in
 user/ngie/release-pkg-fix-tests/cddl/usr.sbin/dtrace/tests: . tools
DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 4DFCED522
To: Garrett Cooper <ngie@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-user@freebsd.org
References: <201605040216.u442GDkd081814@repo.freebsd.org>
From: Bryan Drewery <bdrewery@FreeBSD.org>
Organization: FreeBSD
Message-ID: <57296DC4.5030309@FreeBSD.org>
Date: Tue, 3 May 2016 20:34:28 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0)
 Gecko/20100101 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <201605040216.u442GDkd081814@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "SVN commit messages for the experimental &quot; user&quot;
 src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user/>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 May 2016 03:34:36 -0000

On 5/3/16 7:16 PM, Garrett Cooper wrote:
> Author: ngie
> Date: Wed May  4 02:16:13 2016
> New Revision: 299037
> URL: https://svnweb.freebsd.org/changeset/base/299037
> 
> Log:
>   Use ${PACKAGE}FILES instead of TESTFILES
>   
>   For some odd reason make was getting "lost" with the former idiom and wasn't
>   installing .d and .ksh scripts..
> 
...
> 
> Modified: user/ngie/release-pkg-fix-tests/cddl/usr.sbin/dtrace/tests/tools/genmakefiles.sh
> ==============================================================================
> --- user/ngie/release-pkg-fix-tests/cddl/usr.sbin/dtrace/tests/tools/genmakefiles.sh	Wed May  4 02:11:45 2016	(r299036)
> +++ user/ngie/release-pkg-fix-tests/cddl/usr.sbin/dtrace/tests/tools/genmakefiles.sh	Wed May  4 02:16:13 2016	(r299037)
> @@ -52,7 +52,9 @@ WITH_CTF=YES
>  # This Makefile was generated by \$srcdir${ORIGINDIR#${TOPDIR}}/genmakefiles.sh.
>  #
>  
> -TESTFILES= \\
> +PACKAGE=	tests
> +
> +\${PACKAGE}FILES= \\
>  $tfiles
>  
>  TESTEXES= \\
> 

Presumably because a. PACKAGE is lowercase 'tests' so you get testsFILES
and is b. is plural here rather than singular such as TESTFILES was.

-- 
Regards,
Bryan Drewery